Rollup of 11 pull requests #38958
Merged
Rollup of 11 pull requests #38958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually use trampoline_setup.c and all the `*tf3` business seems related to f80/f128 business. Specifically this'll fix some warnings showing up during builds on OSX.
Add proc_macro crate type
Add a warning not to convert char* from c to Vec<u8> (I thought you could until I asked on irc)
Changed language to stress char is the C meaning (u8) not unicode.
As per @alexcrichton's comment in rust-lang#38607.
…nkov Add test for correct span for type Adds test for and closes rust-lang#27522.
…hton Test for appropriate span on second custom derive Adds test for and closes rust-lang#36935.
…turon std: Remove unused objects from compiler-builtins We don't actually use trampoline_setup.c and all the `*tf3` business seems related to f80/f128 business. Specifically this'll fix some warnings showing up during builds on OSX.
Replace uses of `#[unsafe_destructor_blind_to_params]` with `#[may_dangle]` CC rust-lang#34761 r? @pnkfelix
…meGomez Add more docs for CoerceUnsized and Unsize here be dragons r? @ubsan @steveklabnik
Fix typo in tuple docs r? @steveklabnik
…omez
Expand {Path,OsStr}::{to_str,to_string_lossy} doc examples.
None
Update usage of rustc Add proc_macro crate type
…t, r=nikomatsakis ICH: Add some more test cases for trait impls. r? @nikomatsakis
Update vec.rs Add a warning not to convert char* from c to Vec<u8> (I thought you could until I asked on irc). Reasoning is that it will help people avoid an error that could cause crashes and undefined behaviour. Only drawback is that it could confuse someone not familiar with C, but beginners are unlikely to be using this function anyway.
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=1 |
|
📌 Commit db74f11 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[unsafe_destructor_blind_to_params]with#[may_dangle]#38664, Doc fix #38799, Add more docs for CoerceUnsized and Unsize #38816, Fix typo in tuple docs #38836, Expand {Path,OsStr}::{to_str,to_string_lossy} doc examples. #38839, Update usage of rustc #38841, ICH: Add some more test cases for trait impls. #38849, Update vec.rs #38874