Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usage of rustc #38841

Merged
merged 1 commit into from
Jan 10, 2017
Merged

Update usage of rustc #38841

merged 1 commit into from
Jan 10, 2017

Conversation

F001
Copy link
Contributor

@F001 F001 commented Jan 5, 2017

Add proc_macro crate type

@F001
Update usage of rustc
943c53b 
Add proc_macro crate type
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb
Copy link
Member

eddyb commented Jan 5, 2017

@bors r=steveklabnik rollup

@bors
Copy link
Contributor

bors commented Jan 5, 2017

📌 Commit 943c53b has been approved by steveklabnik

@eddyb
Copy link
Member

eddyb commented Jan 5, 2017

@steveklabnik @alexcrichton Oh, forgot to ask, do we want to backport this?

@alexcrichton
Copy link
Member

I'm personally ok avoiding a backport, seems minor

@frewsxcv frewsxcv mentioned this pull request Jan 9, 2017
Closed
sanxiyn added a commit to sanxiyn/rust that referenced this pull request Jan 10, 2017
@sanxiyn
Rollup merge of rust-lang#38841 - F001:Fix, r=steveklabnik
833d693 
Update usage of rustc

Add proc_macro crate type
@sanxiyn sanxiyn mentioned this pull request Jan 10, 2017
Merged
bors added a commit that referenced this pull request Jan 10, 2017
@bors
Auto merge of #38958 - sanxiyn:rollup, r=sanxiyn
7bffede 
Rollup of 11 pull requests

- Successful merges: #38606, #38607, #38623, #38664, #38799, #38816, #38836, #38839, #38841, #38849, #38874
- Failed merges: #38845
@bors bors merged commit 943c53b into rust-lang:master Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik approved these changes

Assignees

@eddyb eddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@F001 @rust-highfive @eddyb @bors @alexcrichton @steveklabnik