Bad span for self type

[marcusklaas]

The high end of the span of &SomeType in

trait Foo {
    fn handler(self: &SomeType);
}

is incorrectly set to BytePos(0).

[marcusklaas]

It's seems to be caused by this `hack': https://github.com/rust-lang/rust/blob/master/src/libsyntax/ast.rs#L1503-L1521. (Called here: https://github.com/rust-lang/rust/blob/master/src/libsyntax/parse/parser.rs#L4321-L4323)

Weirdly enough, the proper span is shown for diagnostics: play.rust-lang.org

Any pointers, @eddyb?

[eddyb]

Since Self works in impls now, it's probably time to retire that hack and always provide the correct type.
SelfExplicit appears to hold the type (with its correct span), instead of the self argument itself, in this case.

[estebank]

This has been fixed. Can this ticket be closed?