Rollup of 9 pull requests #96108
Merged
Rollup of 9 pull requests #96108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also sort sidebar alphabetically by document filename
The code was broken anyway, if the deaggregator is disabled, it would have ICE on any non-enum Adt
* Links MaybeUninit::uninit_array to meta-tracking issue * Links MaybeUninit::array_assume_init to meta-tracking issue * Unstably constifies MaybeUninit::array_assume_init
…pnkfelix Only add codegen backend to dep info if -Zbinary-dep-depinfo is used I am currently migrating the cg_clif build system from using a binary linked to the codegen backend as rustc replacement to passing `-Zcodegen-backend` instead. Without this PR this would force cargo to rebuild the sysroot on any change to the codegen backend even if I explicitly specify that I want it to be preserved, which would make development of cg_clif a lot slower. If you still want to have changes to the codegen backend invalidate the cargo build cache you can explicitly specify `-Zbinary-dep-depinfo`. cc ``@eddyb`` as the codegen backend was initially added to the depinfo for rust-gpu.
Add missing links in platform support docs I was looking at m68k support and saw that https://doc.rust-lang.org/rustc/platform-support.html and the sidebar there were missing some links to target documentation
…i-obk make unaligned_references lint deny-by-default This lint has been warn-by-default for a year now (since rust-lang#82525), so I think it is time to crank it up a bit. Code that triggers the lint causes UB (without `unsafe`) when executed, so we really don't want people to write code like this.
…comment, r=petrochenkov Improve diagnostics for unterminated nested block comment close rust-lang#95283 (This is my first time try to messing around with rust compiler and might get a lot of things wrong... 🙇 )
…ubilee implement SIMD gather/scatter via vector getelementptr Fixes rust-lang/portable-simd#271 However, I don't *really* know what I am doing here... Cc ``@workingjubilee`` ``@calebzulawski`` I didn't do anything for cranelift -- ``@bjorn3`` not sure if it's okay for that backend to temporarily break. I'm happy to cherry-pick a patch that adds cranelift support. :)
…rochenkov Consider lifetimes when comparing types for equality in MIR validator Closes rust-lang#95978 .
…fJung Remove some now-dead code that was only relevant before deaggregation. The code was broken anyway, if the deaggregator is disabled, it would have ICEd on any non-enum Adt r? ```@RalfJung```
…thomcc [test] Add test cases for untested functions for BTreeMap - add `pop_first()`, `pop_last()`, `get_key_value()` and `try_insert()` test cases
…up, r=dtolnay MaybeUninit array cleanup * Links `MaybeUninit::uninit_array` to meta-tracking issue * Links `MaybeUninit::array_assume_init` to meta-tracking issue * Unstably constifies `MaybeUninit::array_assume_init` Another thing worth mentioning: this splits the const feature flag for `maybe_uninit_uninit_array` into `const_maybe_uninit_uninit_array` to avoid weird cases where only one gets stabilised. Note that it may be desired to keep the `array_assume_init` method linked to its dedicated issue, but at least for now, I decided to link to the meta-tracking issue so that all of the methods lead users to the same place. But I can revert that bit if desired. The meta-tracking issue that I filed is rust-lang#96097.
|
@bors r+ rollup=never p=5 |
|
📌 Commit f559cf9 has been approved by |
|
☀️ Test successful - checks-actions |
|
📣 Toolstate changed by #96108! Tested on commit c842240. 💔 miri on windows: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 16, 2022
Tested on commit rust-lang/rust@c842240. Direct link to PR: <rust-lang/rust#96108> 💔 miri on windows: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb). 💔 miri on linux: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb). 💔 embedded-book on windows: test-pass → test-fail (cc @andre-richter @therealprof @jamesmunns @adamgreig). 💔 embedded-book on linux: test-pass → test-fail (cc @andre-richter @therealprof @jamesmunns @adamgreig).
|
Finished benchmarking commit (c842240): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
Merged
bors bot
added a commit
to rust-embedded/book
that referenced
this pull request
Apr 20, 2022
317: Fix use of unaligned references in example r=eldruin a=adamgreig A recent change in Rust to deny unaligned reference by default (rust-lang/rust#95372) caused the upstream rust build of this book to break: rust-lang/rust#96108 (comment) This PR removes the unaligned references, instead using `addr_of!()` to get a raw pointer to print. Co-authored-by: Adam Greig <[email protected]>
@rustbot label: +perf-regression-triaged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup