Add missing links in platform support docs #94605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also sort sidebar alphabetically by document filename
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. Please see the contribution instructions for more information. |
GuillaumeGomez
approved these changes
Mar 4, 2022
|
Looks good to me, thanks! I'll let someone from the compiler team make the final approval. r? @pnkfelix |
Urgau
reviewed
Mar 4, 2022
| - [armv7-unknown-linux-uclibceabi](platform-support/armv7-unknown-linux-uclibceabi.md) | ||
| - [armv7-unknown-linux-uclibceabihf](platform-support/armv7-unknown-linux-uclibceabihf.md) | ||
| - [aarch64-unknown-none-hermitkernel](platform-support/aarch64-unknown-none-hermitkernel.md) | ||
| - [\*-kmc-solid_\*](platform-support/kmc-solid.md) |
There was a problem hiding this comment.
Suggested change
| - [\*-kmc-solid_\*](platform-support/kmc-solid.md) | |
| - [*-kmc-solid_*](platform-support/kmc-solid.md) |
It's not rendering them correctly with \ before the star.
There was a problem hiding this comment.
Tested it locally on mdBook 0.4.15 it doesn't seem to solve it. I tried a few more combinations and it seems that this works:
Suggested change
| - [\*-kmc-solid_\*](platform-support/kmc-solid.md) | |
| - [\*-kmc-solid_\\*](platform-support/kmc-solid.md) |
as well as
Suggested change
| - [\*-kmc-solid_\*](platform-support/kmc-solid.md) | |
| - [\\*-kmc-solid_\*](platform-support/kmc-solid.md) |
but I'm not seeing a working option with equal number of \ or no \ at all
There was a problem hiding this comment.
@Michcioperz can you clarify whether one of the suggestions you have written here should be adopted?
There was a problem hiding this comment.
This is a bug with mdbook. I posted a fix at rust-lang/mdBook#1785. I recommend leaving it as the original [\*-kmc-solid_\*]. I'll publish a new version of mdbook soon and push a new PR here and that should fix the rendering.
|
r=me once the author has resolved the question about the |
|
📌 Commit c1d5c2b has been approved by |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Apr 15, 2022
Add missing links in platform support docs I was looking at m68k support and saw that https://doc.rust-lang.org/rustc/platform-support.html and the sidebar there were missing some links to target documentation
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 15, 2022
Add missing links in platform support docs I was looking at m68k support and saw that https://doc.rust-lang.org/rustc/platform-support.html and the sidebar there were missing some links to target documentation
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 16, 2022
Add missing links in platform support docs I was looking at m68k support and saw that https://doc.rust-lang.org/rustc/platform-support.html and the sidebar there were missing some links to target documentation
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2022
Rollup of 9 pull requests Successful merges: - rust-lang#93969 (Only add codegen backend to dep info if -Zbinary-dep-depinfo is used) - rust-lang#94605 (Add missing links in platform support docs) - rust-lang#95372 (make unaligned_references lint deny-by-default) - rust-lang#95859 (Improve diagnostics for unterminated nested block comment) - rust-lang#95961 (implement SIMD gather/scatter via vector getelementptr) - rust-lang#96004 (Consider lifetimes when comparing types for equality in MIR validator) - rust-lang#96050 (Remove some now-dead code that was only relevant before deaggregation.) - rust-lang#96070 ([test] Add test cases for untested functions for BTreeMap) - rust-lang#96099 (MaybeUninit array cleanup) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at m68k support and saw that https://doc.rust-lang.org/rustc/platform-support.html and the sidebar there were missing some links to target documentation