deref patterns: bare-bones feature gate and typechecking #122222

Nadrieril · 2024-03-09T03:40:45Z

I am restarting the deref patterns experimentation. This introduces a feature gate under the lang-team experimental feature process, with @cramertj as lang-team liaison (it's been a while though, you still ok with this @cramertj?). Tracking issue: #87121.

This is the barest-bones implementation I could think of:

explicit syntax, reusing box <pat> because that saves me a ton of work;
use Deref as a marker trait (instead of a yet-to-design DerefPure);
no support for mutable patterns with DerefMut for now;
MIR lowering will come in the next PR. It's the trickiest part.

My goal is to let us figure out the MIR lowering part, which might take some work. And hopefully get something working for std types soon.

This is in large part salvaged from @fee1-dead's #119467.

r? @compiler-errors

compiler/rustc_hir_typeck/src/pat.rs

compiler/rustc_middle/src/thir.rs

compiler/rustc_hir_typeck/src/pat.rs

compiler-errors · 2024-03-09T16:12:04Z

pls squash as well, ty

regarding the lang team experiment, it may need a new liaison since @cramertj is no longer on T-lang

Nadrieril · 2024-03-09T17:17:50Z

Ok, I've asked around for a new lang-team liaison

tests/ui/pattern/deref-patterns/typeck.rs

safinaskar · 2024-03-09T20:28:22Z

Please, add more tests. I want to see how this is supposed to work. In particular I'd like to see this code in tests:

let a = Rc::new(vec![0]);
let x = match a {
  box x => x,
}

let a = Rc::new(vec![0]);
let x: &Vec<i32> = match &a {
  box x => x,
}

As well as I understand the first example should not compile (because you cannot move out of Rc), but the second - should

Nadrieril · 2024-03-09T20:48:47Z

These test are not yet possible, because patterns are not lowered correctly to MIR. This is the very first beginnings of implementing the feature, more tests will come in later PRs. (I've just added your examples to my next PR, thank you for them. You are correct about how they should work).

Nadrieril · 2024-03-20T20:33:00Z

We have a liaison!

compiler-errors · 2024-03-20T20:46:16Z

@bors r+

bors · 2024-03-20T20:46:19Z

📌 Commit bf7951d has been approved by compiler-errors

It is now in the queue for this repository.

compiler-errors · 2024-03-20T20:58:01Z

Actually

@bors r-

this needs rebasing

compiler/rustc_pattern_analysis/src/rustc.rs

Co-authored-by: Deadbeef <[email protected]>

compiler-errors · 2024-03-20T21:43:05Z

@bors r+

bors · 2024-03-20T21:43:07Z

📌 Commit 120d357 has been approved by compiler-errors

It is now in the queue for this repository.

…r=compiler-errors deref patterns: bare-bones feature gate and typechecking I am restarting the deref patterns experimentation. This introduces a feature gate under the lang-team [experimental feature](https://github.com/rust-lang/lang-team/blob/master/src/how_to/experiment.md) process, with [`@cramertj` as lang-team liaison](rust-lang/lang-team#88) (it's been a while though, you still ok with this `@cramertj?).` Tracking issue: rust-lang#87121. This is the barest-bones implementation I could think of: - explicit syntax, reusing `box <pat>` because that saves me a ton of work; - use `Deref` as a marker trait (instead of a yet-to-design `DerefPure`); - no support for mutable patterns with `DerefMut` for now; - MIR lowering will come in the next PR. It's the trickiest part. My goal is to let us figure out the MIR lowering part, which might take some work. And hopefully get something working for std types soon. This is in large part salvaged from `@fee1-dead's` rust-lang#119467. r? `@compiler-errors`

…r=compiler-errors deref patterns: bare-bones feature gate and typechecking I am restarting the deref patterns experimentation. This introduces a feature gate under the lang-team [experimental feature](https://github.com/rust-lang/lang-team/blob/master/src/how_to/experiment.md) process, with [``@cramertj`` as lang-team liaison](rust-lang/lang-team#88) (it's been a while though, you still ok with this ``@cramertj?).`` Tracking issue: rust-lang#87121. This is the barest-bones implementation I could think of: - explicit syntax, reusing `box <pat>` because that saves me a ton of work; - use `Deref` as a marker trait (instead of a yet-to-design `DerefPure`); - no support for mutable patterns with `DerefMut` for now; - MIR lowering will come in the next PR. It's the trickiest part. My goal is to let us figure out the MIR lowering part, which might take some work. And hopefully get something working for std types soon. This is in large part salvaged from ``@fee1-dead's`` rust-lang#119467. r? ``@compiler-errors``

r+'d

…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#122222 (deref patterns: bare-bones feature gate and typechecking) - rust-lang#122456 (CFI: Skip non-passed arguments) - rust-lang#122696 (Add bare metal riscv32 target.) - rust-lang#122771 (add some comments to hir::ModuleItems) - rust-lang#122773 (make "expected paren or brace" error translatable) - rust-lang#122795 (Inherit `RUSTC_BOOTSTRAP` when testing wasm) - rust-lang#122799 (Replace closures with `_` when suggesting fully qualified path for method call) - rust-lang#122801 (Fix misc printing issues in emit=stable_mir) - rust-lang#122806 (Make `type_ascribe!` not a built-in) r? `@ghost` `@rustbot` modify labels: rollup

…r=compiler-errors deref patterns: bare-bones feature gate and typechecking I am restarting the deref patterns experimentation. This introduces a feature gate under the lang-team [experimental feature](https://github.com/rust-lang/lang-team/blob/master/src/how_to/experiment.md) process, with [```@cramertj``` as lang-team liaison](rust-lang/lang-team#88) (it's been a while though, you still ok with this ```@cramertj?).``` Tracking issue: rust-lang#87121. This is the barest-bones implementation I could think of: - explicit syntax, reusing `box <pat>` because that saves me a ton of work; - use `Deref` as a marker trait (instead of a yet-to-design `DerefPure`); - no support for mutable patterns with `DerefMut` for now; - MIR lowering will come in the next PR. It's the trickiest part. My goal is to let us figure out the MIR lowering part, which might take some work. And hopefully get something working for std types soon. This is in large part salvaged from ```@fee1-dead's``` rust-lang#119467. r? ```@compiler-errors```

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#122222 (deref patterns: bare-bones feature gate and typechecking) - rust-lang#122358 (Don't ICE when encountering bound regions in generator interior type) - rust-lang#122696 (Add bare metal riscv32 target.) - rust-lang#122773 (make "expected paren or brace" error translatable) - rust-lang#122795 (Inherit `RUSTC_BOOTSTRAP` when testing wasm) - rust-lang#122799 (Replace closures with `_` when suggesting fully qualified path for method call) - rust-lang#122801 (Fix misc printing issues in emit=stable_mir) - rust-lang#122806 (Make `type_ascribe!` not a built-in) Failed merges: - rust-lang#122771 (add some comments to hir::ModuleItems) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-03-21T15:39:49Z

⌛ Testing commit 120d357 with merge 2627e9f...

Rollup merge of rust-lang#122222 - Nadrieril:deref-pat-feature-gate, r=compiler-errors deref patterns: bare-bones feature gate and typechecking I am restarting the deref patterns experimentation. This introduces a feature gate under the lang-team [experimental feature](https://github.com/rust-lang/lang-team/blob/master/src/how_to/experiment.md) process, with [````@cramertj```` as lang-team liaison](rust-lang/lang-team#88) (it's been a while though, you still ok with this ````@cramertj?).```` Tracking issue: rust-lang#87121. This is the barest-bones implementation I could think of: - explicit syntax, reusing `box <pat>` because that saves me a ton of work; - use `Deref` as a marker trait (instead of a yet-to-design `DerefPure`); - no support for mutable patterns with `DerefMut` for now; - MIR lowering will come in the next PR. It's the trickiest part. My goal is to let us figure out the MIR lowering part, which might take some work. And hopefully get something working for std types soon. This is in large part salvaged from ````@fee1-dead's```` rust-lang#119467. r? ````@compiler-errors````

…r=Nadrieril Implement macro-based deref!() syntax for deref patterns Stop using `box PAT` syntax for deref patterns, and instead use a perma-unstable macro. Blocked on rust-lang#122222 r? `@Nadrieril`

Rollup merge of rust-lang#122793 - compiler-errors:deref-pat-syntax, r=Nadrieril Implement macro-based deref!() syntax for deref patterns Stop using `box PAT` syntax for deref patterns, and instead use a perma-unstable macro. Blocked on rust-lang#122222 r? `@Nadrieril`

rustbot assigned compiler-errors Mar 9, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2024

Nadrieril added the F-deref_patterns `#![feature(deref_patterns)]` label Mar 9, 2024

Nadrieril mentioned this pull request Mar 9, 2024

Tracking issue: deref patterns #87121

Open

6 tasks

This comment has been minimized.

Sign in to view

Nadrieril force-pushed the deref-pat-feature-gate branch 2 times, most recently from 8242838 to 2e1f7ab Compare March 9, 2024 04:32

compiler-errors previously requested changes Mar 9, 2024

View reviewed changes

compiler/rustc_hir_typeck/src/pat.rs Outdated Show resolved Hide resolved

compiler/rustc_middle/src/thir.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2024

compiler-errors reviewed Mar 9, 2024

View reviewed changes

compiler/rustc_hir_typeck/src/pat.rs Outdated Show resolved Hide resolved

Nadrieril force-pushed the deref-pat-feature-gate branch from 4cca41b to bf7951d Compare March 9, 2024 16:23

Nadrieril mentioned this pull request Mar 9, 2024

Deref patterns rust-lang/lang-team#88

Open

safinaskar reviewed Mar 9, 2024

View reviewed changes

tests/ui/pattern/deref-patterns/typeck.rs Show resolved Hide resolved

fee1-dead mentioned this pull request Mar 15, 2024

[WIP] implement explicit deref patterns through k#deref #119467

Closed

Nadrieril mentioned this pull request Mar 16, 2024

deref patterns: lower deref patterns to MIR #122598

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2024

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2024

compiler-errors reviewed Mar 20, 2024

View reviewed changes

compiler/rustc_pattern_analysis/src/rustc.rs Show resolved Hide resolved

compiler-errors mentioned this pull request Mar 20, 2024

Implement macro-based deref!() syntax for deref patterns #122793

Merged

Add barest-bones deref patterns

120d357

Co-authored-by: Deadbeef <[email protected]>

Nadrieril force-pushed the deref-pat-feature-gate branch from bf7951d to 120d357 Compare March 20, 2024 21:31

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2024

matthiaskrgr mentioned this pull request Mar 21, 2024

Rollup of 9 pull requests #122815

Closed

workingjubilee mentioned this pull request Mar 21, 2024

Rollup of 9 pull requests #122816

Closed

This was referenced Mar 21, 2024

Rollup of 9 pull requests #122818

Closed

Rollup of 8 pull requests #122822

Merged

bors merged commit 0867025 into rust-lang:master Mar 21, 2024
11 checks passed

rustbot added this to the 1.79.0 milestone Mar 21, 2024

Nadrieril deleted the deref-pat-feature-gate branch March 21, 2024 20:55

Nadrieril mentioned this pull request Jun 25, 2024

Update rustc all at once hacspec/hax#735

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deref patterns: bare-bones feature gate and typechecking #122222

deref patterns: bare-bones feature gate and typechecking #122222

Nadrieril commented Mar 9, 2024

This comment has been minimized.

compiler-errors commented Mar 9, 2024

Nadrieril commented Mar 9, 2024

safinaskar commented Mar 9, 2024

Nadrieril commented Mar 9, 2024 •

edited

Loading

Nadrieril commented Mar 20, 2024

compiler-errors commented Mar 20, 2024

bors commented Mar 20, 2024

compiler-errors commented Mar 20, 2024

compiler-errors commented Mar 20, 2024

bors commented Mar 20, 2024

bors commented Mar 21, 2024

deref patterns: bare-bones feature gate and typechecking #122222

deref patterns: bare-bones feature gate and typechecking #122222

Conversation

Nadrieril commented Mar 9, 2024

This comment has been minimized.

compiler-errors commented Mar 9, 2024

Nadrieril commented Mar 9, 2024

safinaskar commented Mar 9, 2024

Nadrieril commented Mar 9, 2024 • edited Loading

Nadrieril commented Mar 20, 2024

compiler-errors commented Mar 20, 2024

bors commented Mar 20, 2024

compiler-errors commented Mar 20, 2024

compiler-errors commented Mar 20, 2024

bors commented Mar 20, 2024

bors commented Mar 21, 2024

Nadrieril commented Mar 9, 2024 •

edited

Loading