Bug 119199 - Don't update the text track override CSS every time a media element is created.
Summary: Don't update the text track override CSS every time a media element is created.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar, Performance
Depends on:
Blocks:
 
Reported: 2013-07-28 19:13 PDT by Andreas Kling
Modified: 2013-07-28 23:22 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2013-07-28 19:19 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-07-28 19:13:22 PDT 
Don't update the text track override CSS every time a media element is created.
Comment 1 Radar WebKit Bug Importer 2013-07-28 19:13:35 PDT 
<rdar://problem/14572855>
Comment 2 Andreas Kling 2013-07-28 19:19:45 PDT 
Created attachment 207617 [details]
Patch
Comment 3 Darin Adler 2013-07-28 21:39:48 PDT 
Comment on attachment 207617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207617&action=review

> Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:238
> +        updateCaptionStyleSheetOveride();

I would suggest instead changing this function to use early return if already listening for preference changes rather than nesting all this code inside an if statement.
Comment 4 Anders Carlsson 2013-07-28 21:41:31 PDT 
Comment on attachment 207617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207617&action=review

>> Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:238
>> +        updateCaptionStyleSheetOveride();
> 
> I would suggest instead changing this function to use early return if already listening for preference changes rather than nesting all this code inside an if statement.

And fix the spelling while you're at it :)
Comment 5 WebKit Commit Bot 2013-07-28 23:22:40 PDT 
Comment on attachment 207617 [details]
Patch

Clearing flags on attachment: 207617

Committed r153418: <http://trac.webkit.org/changeset/153418>
Comment 6 WebKit Commit Bot 2013-07-28 23:22:42 PDT 
All reviewed patches have been landed.  Closing bug.