Don't update the text track override CSS every time a media element i…

…s created. <http://webkit.org/b/119199> <rdar://problem/14572855> Reviewed by Darin Adler. We should only have to update the CSS if the accessibility caption preferences are changed. This was forcing a full style recalc in every Document any time a media element is instantiated. * page/CaptionUserPreferencesMediaAF.cpp: (WebCore::CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges): Canonical link: https://commits.webkit.org/137189@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Jul 29, 2013 · 3153fa6 · 3153fa6
1 parent 22e63f3
commit 3153fa6
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2013-07-28  Andreas Kling  <[email protected]>
+
+        Don't update the text track override CSS every time a media element is created.
+        <http://webkit.org/b/119199>
+        <rdar://problem/14572855>
+
+        Reviewed by Darin Adler.
+
+        We should only have to update the CSS if the accessibility caption preferences are changed.
+        This was forcing a full style recalc in every Document any time a media element is instantiated.
+
+        * page/CaptionUserPreferencesMediaAF.cpp:
+        (WebCore::CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges):
+
 2013-07-28  Andy Estes  <[email protected]>
 
         Stop exporting Widget::frameRectsChanged()

diff --git a/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp b/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp
@@ -235,9 +235,8 @@ void CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges()
     if (!m_listeningForPreferenceChanges) {
         m_listeningForPreferenceChanges = true;
         CFNotificationCenterAddObserver(CFNotificationCenterGetLocalCenter(), this, userCaptionPreferencesChangedNotificationCallback, kMAXCaptionAppearanceSettingsChangedNotification, 0, CFNotificationSuspensionBehaviorCoalesce);
+        updateCaptionStyleSheetOveride();
     }
-
-    updateCaptionStyleSheetOveride();
 }
 
 void CaptionUserPreferencesMediaAF::captionPreferencesChanged()