[msbuild] Add support for the 'overwrite' metadata for PartialAppManifest items. #21508
Conversation
…fest items. This makes it possible to provide partial app manifests with default values, which can then be overridden in the main Info.plist.
✅ API diff for current PR / commit.NET (No breaking changes)✅ API diff vs stable.NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
| will be merged with the main app manifest (Info.plist). | ||
|
|
||
| Any values in the partial app manifests will override values in the main app | ||
| manifest unless the `Overwrite` metadata is set to `false`. |
There was a problem hiding this comment.
Should this be "Overwrite attribute" instead of metadata?
There was a problem hiding this comment.
| @@ -509,7 +509,7 @@ Copyright (C) 2018 Microsoft. All rights reserved. | |||
| property to run targets that add to the `PartialAppManifest` item group before we process them. | |||
| * Some MSBuild properties can also add values. | |||
|
|
|||
| The precedence is: MSBuild properties can be overridden by the Info.plist, which can be overridden by a partial plist. | |||
| The precedence is: MSBuild properties can be overridden by the Info.plist, which can be overridden by a partial plist (a partial plist can also specify the "Overwrite=false" metadata to not overwrite any existing entries). | |||
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 101 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This makes it possible to provide partial app manifests with default values,
which can then be overridden in the main Info.plist.