[release/9.0.1xx-rc1] [dotnet] Make the RelativeMlaunchPath and XamarinRelativeSdkRootDirectory properties public. #21079
Conversation
…tory properties public. When VS (Windows) needs to figure out where the iOS SDK is located on disk on the Mac machine, the project is evaluated and the`_XamarinRelativeSdkRootDirectory` property is read. Unfortunately an MSBuild optimization recently occurred in VS, where they don't keep underscored properties around after the build, and thus the property XVS needs to inspect isn't there anymore. So make `_XamarinRelativeSdkRootDirectory` and `_RelativeMlaunchPath` public properties by removing the underscore. Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2220369.
📚 [CI Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
❌ [CI Build] Windows Integration Tests failed ❌❌ Failed ❌ Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)
✅ API diff vs stable.NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
❌ [CI Build] Windows Integration Tests failed ❌❌ Failed ❌ Pipeline on Agent |
1 similar comment
❌ [CI Build] Windows Integration Tests failed ❌❌ Failed ❌ Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 100 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
When VS (Windows) needs to figure out where the iOS SDK is located on disk on
the Mac machine, the project is evaluated and
the
_XamarinRelativeSdkRootDirectoryproperty is read. Unfortunately anMSBuild optimization recently occurred in VS, where they don't keep
underscored properties around after the build, and thus the property XVS needs
to inspect isn't there anymore.
So make
_XamarinRelativeSdkRootDirectoryand_RelativeMlaunchPathpublicproperties by removing the underscore.
Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2220369.
Backport of #21074