Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bgen] Fully qualify the RequiredMember and OptionalMember attributes. Fixes #21073. #21076

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[bgen] Fully qualify the RequiredMember and OptionalMember attributes. Fixes #21073. #21076

merged 1 commit into from
Aug 26, 2024

Conversation

rolfbjarne
Copy link
Member

There's a System.Runtime.CompilerServices.RequiredMemberAttribute type,
which may lead to ambiguous type references otherwise.

Fixes #21073.

@rolfbjarne
[bgen] Fully qualify the RequiredMember and OptionalMember attributes. …
d004622 
…Fixes #21073.

There's a `System.Runtime.CompilerServices.RequiredMemberAttribute` type,
which may lead to ambiguous type references otherwise.

Fixes #21073.
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 168 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 6 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (watchOS): All 4 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

2 similar comments
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@dalexsoto
Copy link
Member

dalexsoto commented Aug 22, 2024 •
edited
Loading

@rolfbjarne Should we backport this one to release/8.0.1xx-xcode15.4 ?

@rolfbjarne
Copy link
Member Author

rolfbjarne commented Aug 22, 2024 •
edited
Loading

@rolfbjarne Should we backport this one to release/8.0.1xx-xcode15.4 ?

Yes.

@rolfbjarne
Copy link
Member Author

/sudo backport release/8.0.1xx-xcode15.4

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/8.0.1xx-xcode15.4 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10090715 for more details.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

1 similar comment
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

dalexsoto pushed a commit that referenced this pull request Aug 23, 2024
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/8.0.1xx-xcode15.4] [bgen] Fully qualify the RequiredMember a…
d1de3aa 
…nd OptionalMember attributes. Fixes #21073. (#21101)

There's a `System.Runtime.CompilerServices.RequiredMemberAttribute`
type,
which may lead to ambiguous type references otherwise.

Fixes #21073.


Backport of #21076

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

6 similar comments
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: d004622c575d6c2aab249328a773acf4e2fdd750 [PR build]

@rolfbjarne rolfbjarne merged commit 0d4defc into main Aug 26, 2024
29 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/fully-qualified-attribute branch August 26, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haritha-mohan haritha-mohan haritha-mohan approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RequiredMemberAttribute Ambiguous reference
4 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @haritha-mohan