Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.1xx-preview7] Link with swift #20954

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

dalexsoto
Copy link
Member

The runtime now requires Swift so let's link with it by default
dotnet/runtime@2c70e36

Fixes: https://dev.azure.com/xamarin/public/_build/results?buildId=120547&view=logs&j=71979588-66ac-5e95-831a-69c8cd9b2cd2&t=acd19e4c-afbd-5efc-2769-76bfa657ccbb&l=2196

/Users/builder/azdo/_work/1/s/bin/dotnet/packs/Microsoft.MacCatalyst.Sdk.net9.0_17.5/17.5.9217-net9-p7/targets/Xamarin.Shared.Sdk.targets(1634,3): error : clang++ exited with code 1: [/Users/builder/azdo/_work/1/s/src/Controls/samples/Controls.Sample/Maui.Controls.Sample.csproj::TargetFramework=net9.0-maccatalyst]
/Users/builder/azdo/_work/1/s/bin/dotnet/packs/Microsoft.MacCatalyst.Sdk.net9.0_17.5/17.5.9217-net9-p7/targets/Xamarin.Shared.Sdk.targets(1634,3): error : Undefined symbols for architecture x86_64: [/Users/builder/azdo/_work/1/s/src/Controls/samples/Controls.Sample/Maui.Controls.Sample.csproj::TargetFramework=net9.0-maccatalyst]
/Users/builder/azdo/_work/1/s/bin/dotnet/packs/Microsoft.MacCatalyst.Sdk.net9.0_17.5/17.5.9217-net9-p7/targets/Xamarin.Shared.Sdk.targets(1634,3): error :   "_$sSqMa", referenced from: [/Users/builder/azdo/_work/1/s/src/Controls/samples/Controls.Sample/Maui.Controls.Sample.csproj::TargetFramework=net9.0-maccatalyst]
/Users/builder/azdo/_work/1/s/bin/dotnet/packs/Microsoft.MacCatalyst.Sdk.net9.0_17.5/17.5.9217-net9-p7/targets/Xamarin.Shared.Sdk.targets(1634,3): error :       _$s17pal_swiftbindings7encrypt_3key9nonceData9plaintext10cipherText3tag3aadyxm_SRys5UInt8VGA2KSryAJGAlKtKAA22AEADSymmetricAlgorithmRzlF in libSystem.Security.Cryptography.Native.Apple.a(pal_swiftbindings.o) [/Users/builder/azdo/_work/1/s/src/Controls/samples/Controls.Sample/Maui.Controls.Sample.csproj::TargetFramework=net9.0-maccatalyst]
/Users/builder/azdo/_work/1/s/bin/dotnet/packs/Microsoft.MacCatalyst.Sdk.net9.0_17.5/17.5.9217-net9-p7/targets/Xamarin.Shared.Sdk.targets(1634,3): error :   "_$ss5ErrorMp", referenced from: [/Users/builder/azdo/_work/1/s/src/Controls/samples/Controls.Sample/Maui.Controls.Sample.csproj::TargetFramework=net9.0-maccatalyst]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [CI Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 713bf14a7eb1b5055110d9aabe4c32b4546e6a64 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 713bf14a7eb1b5055110d9aabe4c32b4546e6a64 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 713bf14a7eb1b5055110d9aabe4c32b4546e6a64 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: 713bf14a7eb1b5055110d9aabe4c32b4546e6a64 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 100 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
⚠️ mac-binding-project: No tests selected. Html Report (VSDrops) Download
⚠️ mmp: No tests selected. Html Report (VSDrops) Download
⚠️ mononative: No tests selected. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
⚠️ mtouch: No tests selected. Html Report (VSDrops) Download
⚠️ xammac: No tests selected. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 713bf14a7eb1b5055110d9aabe4c32b4546e6a64 [PR build]

Copy link
Contributor

@ivanpovazan ivanpovazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed to work!

@dalexsoto dalexsoto merged commit 4b65c79 into release/9.0.1xx-preview7 Jul 30, 2024
24 checks passed
@dalexsoto dalexsoto deleted the dev/alex/net9swift branch July 30, 2024 11:12
@rmarinho
Copy link
Member

rmarinho commented Aug 1, 2024

We need this on main too for rc1 package , is failing with same

@rolfbjarne
Copy link
Member

/sudo backport net9.0

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch net9.0 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9984841 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants