Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net9.0] Update dependencies from dotnet/sdk #20949

Merged
merged 12 commits into from
Aug 5, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 28, 2024

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.ILLink.Tasks: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24378.5 (parent: VS.Tools.Net.Core.SDK.Resolver)
    • Microsoft.AspNetCore.App.Ref: from 9.0.0-rc.1.24375.10 to 9.0.0-rc.1.24379.7 (parent: VS.Tools.Net.Core.SDK.Resolver)
    • Microsoft.NETCore.App.Ref: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24378.5 (parent: VS.Tools.Net.Core.SDK.Resolver)
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport: from 9.0.0-preview.7.24365.1 to 9.0.0-rc.1.24373.3 (parent: Microsoft.NETCore.App.Ref)
    • Microsoft.NETCore.App.Ref: from 9.0.0-preview.7.24366.18 to 9.0.0-rc.1.24378.5 (parent: VS.Tools.Net.Core.SDK.Resolver)
    • Microsoft.DotNet.Cecil: from 0.11.5-alpha.24324.1 to 0.11.5-alpha.24365.1 (parent: Microsoft.NETCore.App.Ref)

From https://github.com/dotnet/sdk

  • Subscription: 3727984b-7a79-4ba3-37dd-08dbe6bddf31
  • Build: 20240730.5
  • Date Produced: July 30, 2024 10:19:29 PM UTC
  • Commit: 10803eca35eef6e685924886ba74caf0bd9439ad
  • Branch: refs/heads/main

VS.Tools.Net.Core.SDK.Resolver
 From Version 9.0.100-rc.1.24377.4 -> To Version 9.0.100-rc.1.24377.5

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.NETCore.App.Ref,Microsoft.DotNet.Cecil
 From Version 9.0.0-preview.7.24366.18 -> To Version 9.0.0-rc.1.24376.16 (parent: VS.Tools.Net.Core.SDK.Resolver
Copy link
Contributor

github-actions bot commented Jul 28, 2024

.net ChangeLog for #20949

Level 1

Level 2

Generated using https://github.com/spouliot/dotnet-tools/tree/master/changelog

@dalexsoto
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

dotnet-maestro bot and others added 3 commits July 29, 2024 12:44
VS.Tools.Net.Core.SDK.Resolver
 From Version 9.0.100-rc.1.24377.4 -> To Version 9.0.100-rc.1.24378.3

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.NETCore.App.Ref,Microsoft.DotNet.Cecil
 From Version 9.0.0-preview.7.24366.18 -> To Version 9.0.0-rc.1.24377.4 (parent: VS.Tools.Net.Core.SDK.Resolver
@dalexsoto
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@dalexsoto
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

dotnet-maestro bot and others added 2 commits July 30, 2024 12:55
VS.Tools.Net.Core.SDK.Resolver
 From Version 9.0.100-rc.1.24377.4 -> To Version 9.0.100-rc.1.24380.1

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.NETCore.App.Ref,Microsoft.DotNet.Cecil
 From Version 9.0.0-preview.7.24366.18 -> To Version 9.0.0-rc.1.24378.5 (parent: VS.Tools.Net.Core.SDK.Resolver
@vs-mobiletools-engineering-service2

This comment has been minimized.

dotnet-maestro bot and others added 2 commits July 31, 2024 12:41
VS.Tools.Net.Core.SDK.Resolver
 From Version 9.0.100-rc.1.24377.4 -> To Version 9.0.100-rc.1.24380.5

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.AspNetCore.App.Ref,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.NETCore.App.Ref,Microsoft.DotNet.Cecil
 From Version 9.0.0-preview.7.24366.18 -> To Version 9.0.0-rc.1.24378.5 (parent: VS.Tools.Net.Core.SDK.Resolver
@dalexsoto
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [CI Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 9895620160776050012e918fca3463c6d3cc9ed8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 9895620160776050012e918fca3463c6d3cc9ed8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 9895620160776050012e918fca3463c6d3cc9ed8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: 9895620160776050012e918fca3463c6d3cc9ed8 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 169 tests passed.

Failures

❌ monotouch tests (tvOS) [attempt 2]

1 tests failed, 10 tests passed.
  • monotouch-test/tvOS - simulator/Release (NativeAOT, x64) [dotnet]: TimedOut

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 6 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 65 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mac-binding-project: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (watchOS): All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 9895620160776050012e918fca3463c6d3cc9ed8 [PR build]

@rolfbjarne rolfbjarne self-requested a review as a code owner August 2, 2024 11:47
@ivanpovazan
Copy link
Contributor

Regarding:

monotouch-test/tvOS - simulator/Release (NativeAOT, x64) [dotnet]: TimedOut

The tests are not being executed as the monotouchtest app hangs on several networking tests and gets cancelled not producing any results.

The following tests are problematic:

If they are marked to be skipped on NativeAOT tvOS, the monotouchtest suite runs without a problem.

@ivanpovazan
Copy link
Contributor

Additional finding:

It seems that when I root:

<linker>
  <assembly fullname="System.Net.Http">
    <type fullname="System.Net.Http.SocketsHttpHandler" />
  </assembly>
</linker>

Some of the problems go away.
More specifically MessageHandlers tests pass, which indicates that this might be a trimming problem.

@rolfbjarne
Copy link
Member

I can reproduce this locally too. Attaching lldb yields this stack trace:

(lldb) c
Process 20058 resuming
Process 20058 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = trace
    frame #0: 0x0000000104e2e087 monotouchtest`_monotouchtest_MonoTests_System_Net_Http_MessageHandlerTest__GetHandler(this=0x0000000106017b98, handler_type=<unavailable>) at MessageHandlers.cs:50
   47  					return new SocketsHttpHandler ();
   48  	#endif
   49  				if (handler_type == typeof (NSUrlSessionHandler))
-> 50  					return new NSUrlSessionHandler ();
   51
   52  				throw new NotImplementedException ($"Unknown handler type: {handler_type}");
   53  			}
Target 0: (monotouchtest) stopped.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = trace
  * frame #0: 0x0000000104e2e087 monotouchtest`_monotouchtest_MonoTests_System_Net_Http_MessageHandlerTest__GetHandler(this=0x0000000106017b98, handler_type=<unavailable>) at MessageHandlers.cs:50
    frame #1: 0x0000000104e3414b monotouchtest`_monotouchtest_MonoTests_System_Net_Http_MessageHandlerTest___c__DisplayClass2_0___DnsFailure_b__0_d__MoveNext(this=0x0000000312ce76e0) at MessageHandlers.cs:72
    frame #2: 0x00000001052791c4 monotouchtest`_S_P_CoreLib_System_Runtime_CompilerServices_AsyncMethodBuilderCore__Start<monotouchtest_MonoTests_System_Net_Http_MessageHandlerTest___c__DisplayClass2_0___DnsFailure_b__0_d>(stateMachine=<unavailable>) at AsyncMethodBuilderCore.cs:38
    frame #3: 0x0000000104e3409c monotouchtest`monotouchtest_MonoTests_System_Net_Http_MessageHandlerTest___c__DisplayClass2_0___DnsFailure_b__0 + 44
    frame #4: 0x0000000104e2e265 monotouchtest`_monotouchtest_MonoTests_System_Net_Http_MessageHandlerTest__DnsFailure(this=<unavailable>, handlerType=<unavailable>) at MessageHandlers.cs:71
    frame #5: 0x00000001052a1402 monotouchtest`Internal_CompilerGenerated__Module___<DynamicInvoke>None<S_P_CoreLib_System_Void__Object> + 50
[...]

Disassembly shows it's stuck on a jmp instruction that jumps to itself:

    0x104e2e07b <+123>: movq   %rbx, %rax
    0x104e2e07e <+126>: addq   $0x30, %rsp
    0x104e2e082 <+130>: popq   %rbx
    0x104e2e083 <+131>: popq   %r15
    0x104e2e085 <+133>: popq   %rbp
    0x104e2e086 <+134>: retq
->  0x104e2e087 <+135>: jmp    0x104e2e087               ; <+135> at MessageHandlers.cs:50
    0x104e2e089 <+137>: leaq   0x12661d0(%rip), %rdi     ; vtable for Microsoft_tvOS_System_Net_Http_CFNetworkHandler
    0x104e2e090 <+144>: callq  0x1049c724d               ; RhpNewFast
    0x104e2e095 <+149>: movq   %rax, %rbx
    0x104e2e098 <+152>: movq   %rbx, %rdi

@rolfbjarne rolfbjarne merged commit a9c9497 into net9.0 Aug 5, 2024
27 of 29 checks passed
@rolfbjarne rolfbjarne deleted the darc-net9.0-2b54ae8a-1aa6-4cd1-8dcf-fcf5ed5b2989 branch August 5, 2024 18:16
rolfbjarne pushed a commit that referenced this pull request Sep 24, 2024
…OT (#21285)

This PR reenables failing tests on tvOS/x64 with NativeAOT as the
dotnet/runtime fix became available in:
dotnet/runtime@cd064dd
and got merged in to the xamarin net9.0 branch.

The tests were previously disabled in:
#20949

---
Fixes: #20972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants