[msbuild] Don't support RuntimeIdentifiers for Hot Restart. #20750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to support `RuntimeIdentifiers` (plural) for Hot Restart (because we don't have any scenarios where multiple runtime identifiers applies to iOS; a single runtime identifier can always be used). Adding support would make our code base more complex, so just avoid it by showing an early error if someone tries (which is likely to be accidental anyways). This way we show an actionable error message for a scenario customers will probably be confused about (because the build would fail in rather inexplicable ways) if they run into it. Partial fix for xamarin#19262.
dalexsoto
approved these changes
Jun 20, 2024
mandel-macaque
approved these changes
Jun 20, 2024
haritha-mohan
approved these changes
Jun 21, 2024
emaf
approved these changes
Jul 1, 2024
mauroa
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to support
RuntimeIdentifiers(plural) for Hot Restart(because we don't have any scenarios where multiple runtime identifiers
applies to iOS; a single runtime identifier can always be used).
Adding support would make our code base more complex, so just avoid it by
showing an early error if someone tries (which is likely to be accidental
anyways).
This way we show an actionable error message for a scenario customers will
probably be confused about (because the build would fail in rather
inexplicable ways) if they run into it.
Partial fix for #19262.