-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0.1xx] [msbuild] Copy files to be signed into the correct directory for Hot Restart. Fixes #19278. #19335
Conversation
…Restart. Fixes xamarin#19278. 1. Move the signing to after we copy files that must be signed into the app bundle that will be signed: we sign in the _CodesignHotRestartAppBundle target, so this means the targets _CopyHotRestartBundleResources and _CopyFilesToHotRestartSignedAppDirContents must execute first. 2. Try to clear up some confusion about the directories involved. The HotRestartSignedAppOutputDir property indicates the location of the _signed_ app bundle, which means no files should be added there. Instead files that should be signed (or present when the app launches) must be placed in the HotRestartAppBundlePath directory. 3. Document each property involved to try to avoid more mistakes in the future. Fixes xamarin#19278.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 235 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Move the signing to after we copy files that must be signed into the app bundle
that will be signed: we sign in the _CodesignHotRestartAppBundle target, so this
means the targets _CopyHotRestartBundleResources and _CopyFilesToHotRestartSignedAppDirContents
must execute first.
Try to clear up some confusion about the directories involved. The HotRestartSignedAppOutputDir
property indicates the location of the signed app bundle, which means no files
should be added there. Instead files that should be signed (or present when the
app launches) must be placed in the HotRestartAppBundlePath directory.
Document each property involved to try to avoid more mistakes in the future.
Fixes #19278.
Backport of #19302