Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msbuild] Limit the number of concurrent AOT compilers to the number of processors. #18793

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[msbuild] Limit the number of concurrent AOT compilers to the number of processors. #18793

merged 1 commit into from
Aug 25, 2023

Conversation

rolfbjarne
Copy link
Member

This might fix #17825, but even if it doesn't, it's a good thing to do to not
overload machines.

Ref: #17825

@rolfbjarne
[msbuild] Limit the number of concurrent AOT compilers to the number …
19d89cf 
…of processors.

This might fix xamarin#17825, but even if it doesn't, it's a good thing to do to not
overload machines.

Ref: xamarin#17825
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 19d89cf206f517a11c4ddd735bdd297c156d6701 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 19d89cf206f517a11c4ddd735bdd297c156d6701 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 35 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 19d89cf206f517a11c4ddd735bdd297c156d6701 [PR build]

@rolfbjarne rolfbjarne marked this pull request as ready for review August 24, 2023 11:11
@rolfbjarne rolfbjarne requested review from emaf and mauroa as code owners August 24, 2023 11:11
@rolfbjarne rolfbjarne merged commit 21b2206 into xamarin:main Aug 25, 2023
@rolfbjarne rolfbjarne deleted the msbuild-limit-aot-compiler-concurrency branch August 25, 2023 05:33
@rolfbjarne
Copy link
Member Author

/sudo backport release/7.0.3xx

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.3xx Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8307884 for more details.

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request Aug 25, 2023
@rolfbjarne
[release/7.0.3xx] [msbuild] Limit the number of concurrent AOT compil…
2581f0c 
…ers to the number of processors.

This might fix xamarin#17825, but even if it doesn't, it's a good thing to do to not
overload machines.

Ref: xamarin#17825

Backport of xamarin#18793.
@rolfbjarne rolfbjarne mentioned this pull request Aug 25, 2023
Merged
@rolfbjarne
Copy link
Member Author

/sudo backport release/8.0.1xx-rc1

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/8.0.1xx-rc1 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8308873 for more details.

rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request Aug 25, 2023
@rolfbjarne
[release/8.0.1xx-rc1] [msbuild] Limit the number of concurrent AOT co…
7c9e60a 
…mpilers to the number of processors. (xamarin#18793)

This might fix xamarin#17825, but even if it doesn't, it's a good thing to do
to not overload machines.

Ref: xamarin#17825
rolfbjarne added a commit that referenced this pull request Sep 13, 2023
@rolfbjarne
[release/7.0.3xx] [msbuild] Limit the number of concurrent AOT compil…
a016609 
…ers to the number of processors. (#18817)

This might fix #17825, but even if it doesn't, it's a good thing to do to not
overload machines.

Ref: #17825

Backport of #18793.
@bruno-garcia bruno-garcia mentioned this pull request Sep 16, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haritha-mohan haritha-mohan haritha-mohan approved these changes

@emaf emaf emaf approved these changes

@mauroa mauroa mauroa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building a NET6/NET7 iOS project on agent M2 ARM 64 hangs/freezes
5 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @mauroa @emaf @haritha-mohan