-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Make 'Full' the default link mode for NativeAOT. #18734
[dotnet] Make 'Full' the default link mode for NativeAOT. #18734
Conversation
Make 'Full' the default link mode for all platforms for NativeAOT because: * It will achieve the best app size. * NativeAOT is not a drop-in replacement that's guaranteed to work - there are already known features NativeAOT don't support (and may never support), so this may be an opportunity for app developers (and component vendors) to make their products trimmer safe. * NativeAOT will be in preview in .NET 8, so we can change our mind later if it turns out to cause too many problems. * In some cases NativeAOT might require trimming, because we may optimize/rewrite assemblies to be NativeAOT-compatible to support existing libraries.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 👍
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 232 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Make 'Full' the default link mode for all platforms for NativeAOT because:
already known features NativeAOT don't support (and may never support), so
this may be an opportunity for app developers (and component vendors) to
make their products trimmer safe.
it turns out to cause too many problems.
optimize/rewrite assemblies to be NativeAOT-compatible to support existing
libraries.
This requires #18666 to be merged first, so that ests aren't linked away.