[UIKit] Fix UIKit static method on TvOS #18623
Conversation
This API was missed because the old sim intro tests are not running and we missed it. This was found while working on xcode15. The tvOS attr is missing which defaults to the min version of tvOS when it should be 15. Added a compat implementation so that the API remains that will return null.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/uikit.cs
Outdated
| #if XAMCORE_5_0 | ||
| UIDeferredMenuElement CreateUncached (UIDeferredMenuElementProviderHandler elementProvider); | ||
| #else | ||
| [Internal] | ||
| UIDeferredMenuElement _CreateUncached (UIDeferredMenuElementProviderHandler elementProvider); | ||
| #endif |
There was a problem hiding this comment.
Actually I don't think you need the compat code, just adding the "[TV (15, 0)]" attribute will only change the generated attributes on the member, and that's not a breaking change. The compat code will make the API work on older tvOS versions (when previously it didn't).
There was a problem hiding this comment.
But previously would throw an exception when used, correct? We wonder what is better. We did not get anyone complaining so we might be ok
There was a problem hiding this comment.
I think it's OK to keep doing what we did (throw an exception). It's easy enough for developers to fix, and with the updated attribute they'll even get a warning saying what the problem is.
9c15eb7 to
4f2f31e
Compare
|
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
This API was missed because the old sim intro tests are not running and we missed it. This was found while working on xcode15. The tvOS attr is missing which defaults to the min version of tvOS when it should be 15. Added a compat implementation so that the API remains that will return null. --------- Co-authored-by: GitHub Actions Autoformatter <[email protected]>
This API was missed because the old sim intro tests are not running and we missed it. This was found while working on xcode15. The tvOS attr is missing which defaults to the min version of tvOS when it should be 15. Added a compat implementation so that the API remains that will return null. --------- Co-authored-by: GitHub Actions Autoformatter <[email protected]>
This API was missed because the old sim intro tests are not running and we missed it. This was found while working on xcode15. The tvOS attr is missing which defaults to the min version of tvOS when it should be 15.
Added a compat implementation so that the API remains that will return null.