Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime] Always look for dynamic libraries relative to the root directory first. Fixes #xamarin/maccore@2668. #18121

Merged
merged 1 commit into from
Apr 25, 2023
Merged

[runtime] Always look for dynamic libraries relative to the root directory first. Fixes #xamarin/maccore@2668. #18121

merged 1 commit into from
Apr 25, 2023

Conversation

rolfbjarne
Copy link
Member

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 41f57529c8a63501fa1781ec3107c34ffe745940 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Windows Integration Tests failed ❌

❌ SucceededWithIssues ❌

Pipeline on Agent
Hash: 41f57529c8a63501fa1781ec3107c34ffe745940 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1030.Ventura
Hash: 41f57529c8a63501fa1781ec3107c34ffe745940 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
This was referenced Apr 25, 2023
Merged
Merged
Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 41f57529c8a63501fa1781ec3107c34ffe745940 [PR build]

@rolfbjarne rolfbjarne merged commit edd9881 into xamarin:main Apr 25, 2023
@rolfbjarne rolfbjarne deleted the maccore-issue-2668 branch April 25, 2023 08:22
@rolfbjarne
Copy link
Member Author

/sudo backport release/7.0.2xx-xcode14.2

@rolfbjarne
Copy link
Member Author

/sudo backport release/7.0.2xx-xcode14.3

@rolfbjarne
Copy link
Member Author

/sudo backport release/7.0.3xx

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.2xx-xcode14.2 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.2xx-xcode14.3 Created! The magic is happening here

@rolfbjarne
Copy link
Member Author

/sudo backport release/6.0.4xx-xcode14.2

@rolfbjarne
Copy link
Member Author

/sudo backport release/6.0.4xx-xcode14.3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.3xx Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.4xx-xcode14.2 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.4xx-xcode14.3 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7678672 for more details.

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7678676 for more details.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7678679 for more details.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7678682 for more details.

This was referenced Apr 25, 2023
Merged
Merged
rolfbjarne added a commit that referenced this pull request Apr 27, 2023
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/7.0.2xx-xcode14.3] [runtime] Always look for dynamic librari…
b577489 
…es relative to the root directory first. Fixes #xamarin/maccore@2668. (#18131)

Fixes xamarin/maccore#2668.


Backport of #18121

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
rolfbjarne added a commit that referenced this pull request Apr 27, 2023
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/7.0.3xx] [runtime] Always look for dynamic libraries relativ…
182a8f1 
…e to the root directory first. Fixes #xamarin/maccore@2668. (#18132)

Fixes xamarin/maccore#2668.


Backport of #18121

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
rolfbjarne added a commit that referenced this pull request Apr 27, 2023
@rolfbjarne
[release/6.0.4xx-xcode14.3] [runtime] Always look for dynamic librari…
0390600 
…es relative to the root directory first. Fixes #xamarin/maccore@2668. (#18133)

Fixes xamarin/maccore#2668.

Backport of #18121.
rolfbjarne added a commit that referenced this pull request Apr 27, 2023
@rolfbjarne
[release/6.0.4xx-xcode14.2] [runtime] Always look for dynamic librari…
404f5a8 
…es relative to the root directory first. Fixes #xamarin/maccore@2668. (#18134)

Fixes xamarin/maccore#2668.

Backport of #18121.
@rolfbjarne rolfbjarne mentioned this pull request Apr 28, 2023
Merged
@rolfbjarne
Copy link
Member Author

/sudo backport release/7.0.2xx

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.2xx Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7698492 for more details.

rolfbjarne added a commit that referenced this pull request May 3, 2023
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/7.0.2xx] [runtime] Always look for dynamic libraries relativ…
81cb6a1 
…e to the root directory first. Fixes #xamarin/maccore@2668. (#18177)

Fixes xamarin/maccore#2668.


Backport of #18121

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haritha-mohan haritha-mohan haritha-mohan approved these changes

@tj-devel709 tj-devel709 tj-devel709 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @tj-devel709 @haritha-mohan