Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nullability in various places #18082

Merged
merged 5 commits into from
May 4, 2023
Merged

Enable nullability in various places #18082

merged 5 commits into from
May 4, 2023

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Apr 17, 2023 •
edited
Loading

I started fixing nullability in one place, and then it snowballed a bit and I had to fix nullability in a lot of places.

Most are trivial, except for the generate-frameworks-constants project: I had to create a .NET version of the project in order to compile a .NET version of the tool.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@rolfbjarne
Merge remote-tracking branch 'origin/main' into tests-generator-nulla…
ea2b3f2 
…bility
@rolfbjarne
Fix build.
7d890b3 
New commits in xamarin/Xamarin.MacDev:

* xamarin/Xamarin.MacDev@b454d45 [Xamarin.MacDev] Move compatibility nullability attributes to their own file.
* xamarin/Xamarin.MacDev@bab25f5 [Xamarin.MacDev] Add a few convenience overloads to IAppleSdk.
* xamarin/Xamarin.MacDev@920e87e Update UnitTests.csproj
* xamarin/Xamarin.MacDev@ccc9bd4 Update Xamarin.MacDev.csproj

Diff: https://github.com/xamarin/Xamarin.MacDev/compare/74c95ee1c345cc194a35e6f0c9400f6a55a9b617..b454d454a687d9aa26a382ad16f1a9361b06b074
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMMINI-013.Ventura
Hash: 327d2a82cc1be3aace54ac1c89cc1da88973f6b0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 327d2a82cc1be3aace54ac1c89cc1da88973f6b0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 327d2a82cc1be3aace54ac1c89cc1da88973f6b0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 224 tests passed.

Failures

❌ monotouch tests

1 tests failed, 24 tests passed.
  • monotouch-test/watchOS 32-bits - simulator/Debug: TimedOut

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 327d2a82cc1be3aace54ac1c89cc1da88973f6b0 [PR build]

@rolfbjarne
Copy link
Member Author

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2450).

@rolfbjarne rolfbjarne changed the title [tests] Enable nullability in some generator test files. Enable nullability in various places Apr 26, 2023
@rolfbjarne rolfbjarne marked this pull request as ready for review April 26, 2023 07:16
@rolfbjarne rolfbjarne merged commit d12c046 into xamarin:main May 4, 2023
@rolfbjarne rolfbjarne deleted the tests-generator-nullability branch May 4, 2023 05:39
filipnavara pushed a commit to filipnavara/xamarin-macios that referenced this pull request May 7, 2023
@rolfbjarne @filipnavara
Enable nullability in various places (xamarin#18082)
37500de 
I started fixing nullability in one place, and then it snowballed a bit
and I had to fix nullability in a lot of places.

Most are trivial, except for the `generate-frameworks-constants`
project: I had to create a .NET version of the project in order to
compile a .NET version of the tool.
filipnavara pushed a commit to filipnavara/xamarin-macios that referenced this pull request May 9, 2023
@rolfbjarne @filipnavara
Enable nullability in various places (xamarin#18082)
d570567 
I started fixing nullability in one place, and then it snowballed a bit
and I had to fix nullability in a lot of places.

Most are trivial, except for the `generate-frameworks-constants`
project: I had to create a .NET version of the project in order to
compile a .NET version of the tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haritha-mohan haritha-mohan haritha-mohan approved these changes

@emaf emaf emaf approved these changes

@mauroa mauroa mauroa approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

@mandel-macaque mandel-macaque Awaiting requested review from mandel-macaque mandel-macaque is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mauroa @emaf @haritha-mohan