[linker/trimmer] Add opt-in support for not marking NSObjects in user assemblies. Fixes #15723. #17949

rolfbjarne · 2023-03-30T18:15:42Z

We mark all types that derive from NSObject when we find them in user
assemblies, so that these types may be used in storyboards (where the linker
can't see them), without having to go through hoops to make sure the linker
doesn't remove these types (which would make the storyboard fail to load,
because it would reference types that were linked away).

However, not everybody uses storyboards, so in some cases it may make sense to
link away as much as possible, so make it opt-in to skip this custom marking.

This is an experimental feature, and will break at least some apps. It may
break most apps, but if someone wants to try it out, they're welcome!

It can be turned on by passing --skip-marking-nsobjects-in-user-assemblies=true to mtouch/mmp:

<PropertyGroup>
    <MtouchExtraArgs>--skip-marking-nsobjects-in-user-assemblies=true</MtouchExtraArgs>
</PropertyGroup>

Fixes #15723.

… assemblies. Fixes xamarin#15723. We mark all types that derive from NSObject when we find them in user assemblies, so that these types may be used in storyboards (where the linker can't see them), without having to go through hoops to make sure the linker doesn't remove these types (which would make the storyboard fail to load, because it would reference types that were linked away). However, not everybody uses storyboards, so in some cases it may make sense to link away as much as possible, so make it opt-in to skip this custom marking. This is an experimental feature, and will break at least some apps. It may break most apps, but if someone wants to try it out, they're welcome! Fixes xamarin#15723.

dalexsoto

Just missing in the PR description or a doc under docs describing how would a user opt in into this experimental feature 👍

emaf · 2023-04-11T18:05:43Z

msbuild/Xamarin.MacDev.Tasks/Tasks/ParseBundlerArgumentsTaskBase.cs

@@ -165,6 +168,9 @@ public override bool Execute ()
 						item.SetMetadata ("Value", value.Substring (colon + 1));
 						envVariables.Add (item);
 						break;
+					case "skip-marking-nsobjects-in-user-assemblies":
+						SkipMarkingNSObjectsInUserAssemblies = ParseBool (value) ? "false" : "true";


This looks weird. If the extra arg skip-marking-nsobjects-in-user-assemblies is true, we set SkipMarkingNSObjectsInUserAssemblies to false?

@emaf Good catch! I've now fixed this.

…s-in-user-assemblies

vs-mobiletools-engineering-service2 · 2023-04-12T15:09:00Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 5f6f84c0ff7097d5276e84c2114c37356ce5d608 [PR build]

vs-mobiletools-engineering-service2 · 2023-04-12T15:11:24Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 5f6f84c0ff7097d5276e84c2114c37356ce5d608 [PR build]

vs-mobiletools-engineering-service2 · 2023-04-12T15:19:43Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1030.Ventura
Hash: 5f6f84c0ff7097d5276e84c2114c37356ce5d608 [PR build]

vs-mobiletools-engineering-service2 · 2023-04-12T15:19:53Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: 5f6f84c0ff7097d5276e84c2114c37356ce5d608 [PR build]

vs-mobiletools-engineering-service2 · 2023-04-12T15:21:06Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 5f6f84c0ff7097d5276e84c2114c37356ce5d608 [PR build]

vs-mobiletools-engineering-service2 · 2023-04-12T18:38:40Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 5f6f84c0ff7097d5276e84c2114c37356ce5d608 [PR build]

This comment has been minimized.

Sign in to view

Merge branch 'main' into skip-marking-nsobjects-in-user-assemblies

6c631c0

This comment has been minimized.

Sign in to view

Fix build problem.

995ffee

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review April 11, 2023 05:13

rolfbjarne requested review from emaf and mauroa as code owners April 11, 2023 05:13

dalexsoto approved these changes Apr 11, 2023

View reviewed changes

mauroa approved these changes Apr 11, 2023

View reviewed changes

tj-devel709 approved these changes Apr 11, 2023

View reviewed changes

emaf reviewed Apr 11, 2023

View reviewed changes

rolfbjarne added 2 commits April 12, 2023 14:09

Merge remote-tracking branch 'origin/main' into skip-marking-nsobject…

4a314ce

…s-in-user-assemblies

Fix boolean logic.

5f6f84c

emaf approved these changes Apr 13, 2023

View reviewed changes

rolfbjarne merged commit 4dbd98b into xamarin:main Apr 13, 2023

rolfbjarne deleted the skip-marking-nsobjects-in-user-assemblies branch April 13, 2023 14:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[linker/trimmer] Add opt-in support for not marking NSObjects in user assemblies. Fixes #15723. #17949

[linker/trimmer] Add opt-in support for not marking NSObjects in user assemblies. Fixes #15723. #17949

rolfbjarne commented Mar 30, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto left a comment

emaf Apr 11, 2023

rolfbjarne Apr 12, 2023

vs-mobiletools-engineering-service2 commented Apr 12, 2023

vs-mobiletools-engineering-service2 commented Apr 12, 2023

vs-mobiletools-engineering-service2 commented Apr 12, 2023

vs-mobiletools-engineering-service2 commented Apr 12, 2023

vs-mobiletools-engineering-service2 commented Apr 12, 2023

vs-mobiletools-engineering-service2 commented Apr 12, 2023

[linker/trimmer] Add opt-in support for not marking NSObjects in user assemblies. Fixes #15723. #17949

[linker/trimmer] Add opt-in support for not marking NSObjects in user assemblies. Fixes #15723. #17949

Conversation

rolfbjarne commented Mar 30, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto left a comment

Choose a reason for hiding this comment

emaf Apr 11, 2023

Choose a reason for hiding this comment

rolfbjarne Apr 12, 2023

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Apr 12, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Apr 12, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

✅ Generator diff

vs-mobiletools-engineering-service2 commented Apr 12, 2023

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Apr 12, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Apr 12, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Apr 12, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

rolfbjarne commented Mar 30, 2023 •

edited

Loading