[AVFoundation] Fix callback signature for the AVAudioSinkNode constructor. Fixes #17575. #17785

rolfbjarne · 2023-03-14T09:00:36Z

The callback to the AVAudioSinkNode constructor was declared incorrectly, and
if used, the app would crash at runtime.

This fix does a few things:

Creates an overload with callback signature that matches the native API
(using IntPtrs).
Writes a custom version for the broken callback signature to make it work
(and this overload is obsoleted, and removed in XAMCORE_5_0).
Adds a third overload with the ideal signature.
Adds tests.

github-actions · 2023-03-14T09:04:49Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

src/avfoundation.cs

tj-devel709

Small typo in param name, but otherwise LGTM

…tor. Fixes xamarin#17755. The callback to the AVAudioSinkNode constructor was declared incorrectly, and if used, the app would crash at runtime. This fix does a few things: * Creates an overload with callback signature that matches the native API (using IntPtrs). * Writes a custom version for the broken callback signature to make it work (and this overload is obsoleted, and removed in XAMCORE_5_0). * Adds a third overload with the ideal signature. * Adds tests. Fixes xamarin#17755.

This reverts commit c4fd2b9e5aa44e90f0cf4ef4a735ce1c2bcdab84.

…-17755

vs-mobiletools-engineering-service2 · 2023-04-20T07:32:28Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 825f3ffd53d8aeac3241b8b911f279a4c1cd3ce6 [PR build]

vs-mobiletools-engineering-service2 · 2023-04-20T07:37:49Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-04-20T07:38:04Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-04-20T07:43:37Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 825f3ffd53d8aeac3241b8b911f279a4c1cd3ce6 [PR build]

vs-mobiletools-engineering-service2 · 2023-04-20T07:44:02Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMMINI-013.Ventura
Hash: 825f3ffd53d8aeac3241b8b911f279a4c1cd3ce6 [PR build]

vs-mobiletools-engineering-service2 · 2023-04-20T11:10:58Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 825f3ffd53d8aeac3241b8b911f279a4c1cd3ce6 [PR build]

rolfbjarne requested review from mandel-macaque and dalexsoto as code owners March 14, 2023 09:00

rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Mar 14, 2023

rolfbjarne changed the title ~~[AVFoundation] Fix callback signature fo the AVAudioSinkNode constructor. Fixes #17755.~~ [AVFoundation] Fix callback signature fo the AVAudioSinkNode constructor. Fixes #17575. Mar 14, 2023

This comment has been minimized.

Sign in to view

tj-devel709 reviewed Mar 14, 2023

View reviewed changes

src/avfoundation.cs Outdated Show resolved Hide resolved

tj-devel709 reviewed Mar 14, 2023

View reviewed changes

rolfbjarne changed the title ~~[AVFoundation] Fix callback signature fo the AVAudioSinkNode constructor. Fixes #17575.~~ [AVFoundation] Fix callback signature for the AVAudioSinkNode constructor. Fixes #17575. Mar 14, 2023

This comment has been minimized.

Sign in to view

mandel-macaque approved these changes Mar 14, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Mar 15, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

haritha-mohan approved these changes Mar 15, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne added 8 commits April 17, 2023 16:31

Try and see if this works.

b0ea815

Add more asserts.

8aeb494

Add debug spew.

7a3da41

Try adding an entitlement.

5a21dca

Detect input devices.

b537ec5

Add more recording availability checks.

39f6f07

Fix build on watchOS.

10438cf

rolfbjarne force-pushed the avaudiosinknode-issue-17755 branch from 5be9934 to 10438cf Compare April 17, 2023 14:31

This comment has been minimized.

Sign in to view

rolfbjarne added 3 commits April 20, 2023 08:08

Cleanup

d5a8c3f

Revert "Try adding an entitlement."

5844baf

This reverts commit c4fd2b9e5aa44e90f0cf4ef4a735ce1c2bcdab84.

Merge remote-tracking branch 'origin/main' into avaudiosinknode-issue…

825f3ff

…-17755

rolfbjarne merged commit e8c8f00 into xamarin:main Apr 20, 2023

rolfbjarne deleted the avaudiosinknode-issue-17755 branch April 20, 2023 11:15

[AVFoundation] Fix callback signature for the AVAudioSinkNode constructor. Fixes #17575. #17785

[AVFoundation] Fix callback signature for the AVAudioSinkNode constructor. Fixes #17575. #17785

Conversation

rolfbjarne commented Mar 14, 2023 • edited Loading

github-actions bot commented Mar 14, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 20, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Apr 20, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Apr 20, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Apr 20, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Apr 20, 2023

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Apr 20, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

rolfbjarne commented Mar 14, 2023 •

edited

Loading