[Windows build perf] UnpackLibraryResources should consume .NET assemblies from the Mac installation #19511
Assignees
Labels
delighter-sc
msbuild
Issues affecting our msbuild tasks/targets
performance
If an issue or pull request is related to performance
windows-only
The issue only occur on Windows
Milestone
Comments
|
We might be able to execute this task fully on Windows, as far as I can tell there's nothing that needs to happen on a Mac. |
15 tasks
rolfbjarne
added a commit
that referenced
this issue
Sep 25, 2024
…assemblies. Fixes #19511. We know BCL won't have library resources to unpack, so there's no need to spend any time looking at them. This also required porting the UnpackLibraryResources task to use System.Reflection.Metadata, because MetadataLoadContext requires the reference assemblies to be available to resolve assembly dependencies (and the idea is to not have to pass any reference assemblies to the task). Fixes #19511.
rolfbjarne
added a commit
that referenced
this issue
Oct 2, 2024
…assemblies. Fixes #19511. (#21305) We know BCL won't have library resources to unpack, so there's no need to spend any time looking at them. This also required porting the UnpackLibraryResources task to use System.Reflection.Metadata, because MetadataLoadContext requires the reference assemblies to be available to resolve assembly dependencies (and the idea is to not have to pass any reference assemblies to the task). Fixes #19511. Fixes #15030.
rolfbjarne
added a commit
that referenced
this issue
Oct 22, 2024
…assemblies. Fixes #19511. (#21305) We know BCL won't have library resources to unpack, so there's no need to spend any time looking at them. This also required porting the UnpackLibraryResources task to use System.Reflection.Metadata, because MetadataLoadContext requires the reference assemblies to be available to resolve assembly dependencies (and the idea is to not have to pass any reference assemblies to the task). Fixes #19511. Fixes #15030.
rolfbjarne
added a commit
that referenced
this issue
Oct 28, 2024
…assemblies. Fixes #19511. (#21305) We know BCL won't have library resources to unpack, so there's no need to spend any time looking at them. This also required porting the UnpackLibraryResources task to use System.Reflection.Metadata, because MetadataLoadContext requires the reference assemblies to be available to resolve assembly dependencies (and the idea is to not have to pass any reference assemblies to the task). Fixes #19511. Fixes #15030.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When building an iOS project remotely from Windows, the
UnpackLibraryResourcestaks is comparing/copying ~ 150 .NET assemblies over to the Mac that already exist in the SDK installation. The task seems to have enough information to avoid copying those and take them from the installation directory on the Mac.This also impacts incremental builds because even though we cache files on the Mac, comparing 150 files takes a considerable amount of time.
Expected Behavior
Files that are part of the SDK installed on the Mac should be consumed from there
Actual Behavior
We are copying unnecesary files over the network
Build Logs
Note: this logs were taken when building from a Dev Box
Binlogs.zip
The text was updated successfully, but these errors were encountered: