Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create target to output the mlaunch arguments to install+launch an app #18359

Closed
rolfbjarne opened this issue May 26, 2023 · 1 comment · Fixed by #18446
Closed

Create target to output the mlaunch arguments to install+launch an app #18359

rolfbjarne opened this issue May 26, 2023 · 1 comment · Fixed by #18446
Assignees
@rolfbjarne
Labels
enhancement The issue or pull request is an enhancement
Milestone
Future

Comments

@rolfbjarne
Copy link
Member

Create an MSBuild target to output the mlaunch arguments to install + launch an app.

  1. msbuild property that holds the command
  2. msbuild property to specify an output file to dump that command to
@rolfbjarne rolfbjarne added the enhancement The issue or pull request is an enhancement label May 26, 2023
@rolfbjarne rolfbjarne added this to the Future milestone May 26, 2023
@rolfbjarne rolfbjarne self-assigned this May 26, 2023
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Jun 14, 2023
@rolfbjarne
[dotnet] Add targets to compute mlaunch arguments for installing and …
a68c61e 
…launching mobile apps. Fixes xamarin#18359.

Add public targets to compute the mlaunch command lines for installing and launching mobile apps.

These new targets are:

* ComputeMlaunchInstallArguments
* ComputeMlaunchRunArguments

As part of this change, also create a few new public properties:

* MlaunchPath
* MlaunchRunArguments
* MlaunchInstallArguments
* MlaunchRunScript
* MlaunchInstallScript

If the *Script variables are set, the corresponding target will create a
script file with the path to mlaunch + the corresponding arguments.

Otherwise, it's also possible to get the arguments directly from the build
log.

Fixes xamarin#18359.
@rolfbjarne rolfbjarne mentioned this issue Jun 14, 2023
Merged
@rolfbjarne
Copy link
Member Author

@Redth so we'll have two targets to execute:

  • ComputeMlaunchInstallArguments
  • ComputeMlaunchRunArguments

Set the following properties to have these targets write the arguments to the file specified by the properties:

  • MlaunchRunScript
  • MlaunchInstallScript

For whenever you can read properties from the build directly, these properties will contain the same information:

  • MlaunchPath
  • MlaunchRunArguments
  • MlaunchInstallArguments

rolfbjarne added a commit that referenced this issue Jun 15, 2023
@rolfbjarne
[dotnet] Add targets to compute mlaunch arguments for installing and …
7df3eb1 
…launching mobile apps. Fixes #18359. (#18446)

Add public targets to compute the mlaunch command lines for installing
and launching mobile apps.

These new targets are:

* ComputeMlaunchInstallArguments
* ComputeMlaunchRunArguments

As part of this change, also create a few new public properties:

* MlaunchPath
* MlaunchRunArguments
* MlaunchInstallArguments
* MlaunchRunScript
* MlaunchInstallScript

If the *Script variables are set, the corresponding target will create a
script file with the path to mlaunch + the corresponding arguments.

Otherwise, it's also possible to get the arguments directly from the
build log.

Fixes #18359.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Jun 15, 2023
@rolfbjarne
[release/7.0.2xx-xcode14.3] [dotnet] Add targets to compute mlaunch a…
d620bf6 
…rguments for installing and launching mobile apps. Fixes xamarin#18359.

Add public targets to compute the mlaunch command lines for installing
and launching mobile apps.

These new targets are:

* ComputeMlaunchInstallArguments
* ComputeMlaunchRunArguments

As part of this change, also create a few new public properties:

* MlaunchPath
* MlaunchRunArguments
* MlaunchInstallArguments
* MlaunchRunScript
* MlaunchInstallScript

If the *Script variables are set, the corresponding target will create a
script file with the path to mlaunch + the corresponding arguments.

Otherwise, it's also possible to get the arguments directly from the
build log.

Fixes xamarin#18359.

Backport of xamarin#18446.
@rolfbjarne rolfbjarne mentioned this issue Jun 15, 2023
Merged
rolfbjarne added a commit that referenced this issue Jun 16, 2023
@rolfbjarne
[release/7.0.2xx-xcode14.3] [dotnet] Add targets to compute mlaunch a…
c0f492f 
…rguments for installing and launching mobile apps. Fixes #18359. (#18451)

Add public targets to compute the mlaunch command lines for installing
and launching mobile apps.

These new targets are:

* ComputeMlaunchInstallArguments
* ComputeMlaunchRunArguments

As part of this change, also create a few new public properties:

* MlaunchPath
* MlaunchRunArguments
* MlaunchInstallArguments
* MlaunchRunScript
* MlaunchInstallScript

If the *Script variables are set, the corresponding target will create a
script file with the path to mlaunch + the corresponding arguments.

Otherwise, it's also possible to get the arguments directly from the
build log.

Fixes #18359.

Backport of #18446.

---------

Co-authored-by: GitHub Actions Autoformatter <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rolfbjarne rolfbjarne

Labels
enhancement The issue or pull request is an enhancement
Projects
None yet
Milestone
Future
1 participant
@rolfbjarne