Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port 'Actions' demo to Vala #153

Merged
merged 4 commits into from
May 29, 2024
Merged

Conversation

BharatAtbrat
Copy link
Contributor

Add Vala code for Actions demo

Workbench keeps removing the spaces before the brackets of the function parameter, hence the lack of spaces.
This wasn't the case with the PR for the Dialog demo

Let me know if there are any other fixes or improvements :)

Add Vala code for Actions demo
src/Actions/main.vala Outdated Show resolved Hide resolved
src/Actions/main.vala Outdated Show resolved Hide resolved
src/Actions/main.vala Outdated Show resolved Hide resolved
src/Actions/main.vala Outdated Show resolved Hide resolved
message format change as suggested by @lw64
Use same action name for 'scale_action' message parameter
Copy link
Contributor

@Diego-Ivan Diego-Ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, thanks!

src/Actions/main.vala Outdated Show resolved Hide resolved
src/Actions/main.vala Outdated Show resolved Hide resolved
Copy link
Contributor

@Diego-Ivan Diego-Ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting this demo!

@sonnyp sonnyp merged commit 8e5a8a0 into workbenchdev:main May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants