Remove regionCode attribute #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CFC is going to go out later this week. |
rsolomakhin
approved these changes
Jan 17, 2019
|
Decision announced to remove. |
domenic
approved these changes
Jan 24, 2019
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 29, 2019
The regionCode attribute was removed in spec side[1]. FYI, the attribute was behind runtime flag and have never shipped. So, we don't need to send intents to blink-dev. [1] w3c/payment-request#823 Bug: 925722 Change-Id: I85b370770141b1caf69389e399358b82ad071b89 Reviewed-on: https://chromium-review.googlesource.com/c/1438981 Reviewed-by: Rouslan Solomakhin <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Commit-Queue: Jinho Bang <[email protected]> Cr-Commit-Position: refs/heads/master@{#626895}
8 tasks
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Jan 29, 2020
w3c/payment-request#765 and w3c/payment-request#823 removed the languageCode and regionCode members from the PaymentAddress interface. w3c/payment-request@3fb7e37 w3c/payment-request@5906b72
queengooborg
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Jan 30, 2020
w3c/payment-request#765 and w3c/payment-request#823 removed the languageCode and regionCode members from the PaymentAddress interface. w3c/payment-request@3fb7e37 w3c/payment-request@5906b72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #816
The following tasks have been completed:
Implementation commitment:
Optional, impact on Payment Handler spec?
Preview | Diff