-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "geolocation task queue" #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some nits.
Co-authored-by: Reilly Grant <[email protected]>
Pretty sure that a microtask can only be queued in the context of a task. When you're in parallel you have to queue a task. |
@annevk, ok, I was a bit unsure. I'll queue a task, but was unsure what task source to go with... should I mint a new one for geolocation? Or do you have a suggestion for an existing one? |
Gave this some thought... as every browser has its own dedicated location service manager, I'm going to mint a "geolocation task source". |
@annevk, added the new "geolocation task source" 🥫. |
Seems reasonable. You want to use "queue a global task" and probably pass "this's relevant global object" (that you put in a variable before going in parallel). |
Closes #80
@annevk, I did as you suggested:
As I had to re-indent the algorithm, probably best viewed in PR-Preview.
Preview | Diff