Remove fold angle value from the specification. #58
Conversation
index.html
Outdated
| @@ -90,9 +90,7 @@ | |||
| <section id='abstract'> | |||
| <p> | |||
| This document specifies an API that allows web applications to request the | |||
There was a problem hiding this comment.
and be notified of changes?
| @@ -159,7 +154,6 @@ <h2> | |||
| <pre class="idl"> | |||
| [SecureContext, Exposed=(Window)] | |||
| interface ScreenFold : EventTarget { | |||
There was a problem hiding this comment.
We should rename ScreenFold etc as well, maybe different PR
There was a problem hiding this comment.
Yes, part of the rename.
d811ebc
to
da8aca9
Compare
|
LGTM |
There was a problem hiding this comment.
Thanks! Some nits as suggestions. In addition:
The spec currently lacks a "posture" definition. Given this term can mean many things, we should explicitly define this term in the context of this specification.
The spec has definitions for "current posture" and "posture mode" which is good.
index.html
Outdated
| when the device folds, it physically can be different form factor. The main interest in knowing the posture is because there | ||
| are opportunities in responsive design that enable new user experiences. |
There was a problem hiding this comment.
| when the device folds, it physically can be different form factor. The main interest in knowing the posture is because there | |
| are opportunities in responsive design that enable new user experiences. | |
| when the device folds, it can be a physically different form factor. The main interest in knowing the posture is to enable new user experiences with responsive design. |
index.html
Outdated
| provide a different layout for it depending on the state of the angle of the fold. Additionally, developers can | ||
| adapt content depending on various “postures” and potentially also animate some of these transitions. You can | ||
| refer to a description of use cases. | ||
| provide a different layout for it depending on the state in which the device is being used. |
There was a problem hiding this comment.
| provide a different layout for it depending on the state in which the device is being used. | |
| provide a different layout for it depending on the posture state in which the device is being used. |
Let make these improvements as follow up.
|
Some editors and implementers of the Screen Fold API attended the Second Screen WG/CG Virtual meeting to discuss this API. During that meeting that group made the following resolution for DAS WG consideration RESOLUTION: Drop ScreenFold.angle from the Screen Fold API first version (for DAS WG consideration) A following commit will rename the specification so references can ber renamed to better match what we're exposing. Fixes w3c#56, w3c#45.
da8aca9
to
29d96ea
Compare
SGTM. Opened https://github.com/w3c/screen-fold/issues/59 |
|
All - please review this PR and submit your feedback by the end of next Monday, 8 March 2021. |
|
This PR has received adequate review and is ready to land. |
Some editors and implementers of the Screen Fold API attended the Second
Screen WG/CG Virtual meeting to discuss this API. During that meeting
that group made the following resolution for DAS WG consideration
RESOLUTION: Drop ScreenFold.angle from the Screen Fold API first version (for DAS WG consideration)
A following commit will rename the specification so references can ber
renamed to better match what we're exposing.
Closes #56, #45.
Preview | Diff