Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

progressbar: clarify described-by #1671

Merged
merged 2 commits into from
Jan 13, 2022
Merged

progressbar: clarify described-by #1671

merged 2 commits into from
Jan 13, 2022

Conversation

pkra
Copy link
Member

@pkra pkra commented Jan 11, 2022 •
edited by pr-preview bot
Loading

Resolves #1654

Preview | Diff

@pkra
Copy link
Member Author

pkra commented Jan 11, 2022

I wasn't sure if we should replace the next "status" with "progressbar" - since status is vague (i.e., I guess could point within the progressbar) I think that would go beyond an editorial change.

@pkra pkra requested a review from scottaohara January 11, 2022 12:15
@pkra pkra added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Jan 11, 2022
@pkra pkra requested a review from jnurthen January 11, 2022 12:15
@pkra pkra mentioned this pull request Jan 11, 2022
Closed
scottaohara
scottaohara reviewed Jan 11, 2022
View reviewed changes
index.html Outdated Show resolved Hide resolved
@pkra @scottaohara
Update index.html
bc7be54 
Co-authored-by: Scott O'Hara <[email protected]>
@pkra pkra requested a review from scottaohara January 11, 2022 14:23
MelSumner
MelSumner approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pkra pkra added this to the ARIA 1.3 milestone Jan 12, 2022
carmacleod
carmacleod approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Looks good.
Thanks @pkra !

@pkra pkra self-assigned this Jan 13, 2022
@pkra pkra merged commit e1d9d12 into main Jan 13, 2022
@pkra pkra deleted the issue1654 branch January 13, 2022 18:14
github-actions bot added a commit that referenced this pull request Jan 13, 2022
@pkra @github-actions
progressbar: clarify described-by (#1671)
96f15f5 
SHA: e1d9d12
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelSumner MelSumner MelSumner approved these changes

@scottaohara scottaohara scottaohara approved these changes

@carmacleod carmacleod carmacleod approved these changes

@jnurthen jnurthen Awaiting requested review from jnurthen

Assignees

@pkra pkra

Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Milestone
2023
Development

Successfully merging this pull request may close these issues.

Clarify statement in progressbar role definition
4 participants
@pkra @carmacleod @scottaohara @MelSumner