role=note fleshed out a little. #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Language a little less terse. Explicit mention of aria-details to associate a note with another element.
scottaohara
previously requested changes
Nov 5, 2021
added 2 commits
November 5, 2021 16:04
Normative "SHOULD" replaced with informative "can". Use cases for aria-describedby and aria-details added
|
Should this PR be linked to a particular issue? |
|
@cookiecrook it arose from #1629 |
|
jnurthen marked as non substantive for IPR from ash-nazg. |
Closed
scottaohara
reviewed
Nov 24, 2021
I have made edits and provided examples to flesh out the work that Brennan has started, while addressing the concerns I had noted. @brennanyoung I would ask that you review to make sure this is now clear from your end. If so, then we can merge this branch into yours, and then request the working group to provide further review to move this along.
|
While my commit message mentioned I was creating a separate PR to review and to then merge into this branch, unfortunately something was not working with that process, and my separate branch kept errorring out. Fortunately, through the magic of version control, we can revert / make changes to anything that need be. But as my commit message mentions, @brennanyoung please review these updates when you can. Thanks |
|
@jnurthen hmm, tried to remove myself from the reviewers since i've now added a bunch of content to this PR - clearly that didn't work. Worth getting someone else besides me to review now. |
jnurthen
requested changes
Dec 22, 2021
if one is going to make an example to show how to use `role=note`, one should remember to actually use `role=note`...
jnurthen
reviewed
Dec 23, 2021
Co-authored-by: James Nurthen <[email protected]>
jnurthen
approved these changes
Mar 8, 2022
cookiecrook
approved these changes
Jan 19, 2023
adampage
approved these changes
Jan 19, 2023
Co-authored-by: James Craig <[email protected]>
Co-authored-by: Adam Page <[email protected]>
|
thank you @adampage and @cookiecrook @jnurthen seems we can merge this now :) |
github-actions bot
added a commit
that referenced
this pull request
Mar 3, 2023
SHA: abbef89 Reason: push, by pkra Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jnurthen
added a commit
that referenced
this pull request
Oct 10, 2023
Language a little less terse. Explicit mention of aria-details to associate a note with another element. Co-authored-by: Brennan Young <[email protected]> Co-authored-by: Scott O'Hara <[email protected]> Co-authored-by: James Nurthen <[email protected]> Co-authored-by: James Craig <[email protected]> Co-authored-by: Adam Page <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language a little less terse. Explicit mention of aria-details to associate a note with another element.
Preview | Diff
Preview | Diff