Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify "current element" #1460

Merged
merged 1 commit into from
May 6, 2021
Merged

clarify "current element" #1460

merged 1 commit into from
May 6, 2021

Conversation

pkra
Copy link
Member

@pkra pkra commented Apr 16, 2021 •
edited by pr-preview bot
Loading

  • in focus management, to "element being focused"
  • otherwise, "the element" or "the element with xxx"

Resolves #1152

Preview | Diff

@pkra
clarify "current element"
61c6310 
* in focus management, to "element being focused"
* otherwise, "the element" or "the element with xxx"

Resolves w3c#1152
@pkra pkra requested a review from carmacleod April 16, 2021 13:57
@pkra pkra mentioned this pull request Apr 16, 2021
Closed
@jnurthen jnurthen requested review from jnurthen, charmarkk and cookiecrook and removed request for jnurthen April 22, 2021 17:26
@pkra
Copy link
Member Author

pkra commented Apr 22, 2021 •
edited
Loading

Note to self: might get a merge conflict from #1467 which also changes one instance of "current element" (the same way though, I think).

carmacleod
carmacleod approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thanks, @pkra

charmarkk
charmarkk approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@charmarkk charmarkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, many thanks @pkra!

@jnurthen jnurthen merged commit e482b6f into w3c:main May 6, 2021
jnurthen pushed a commit that referenced this pull request May 6, 2021
@pkra @jnurthen
clarify "current element" (#1460)
86bdb82 
* in focus management, to "element being focused"
* otherwise, "the element" or "the element with xxx"
Resolves #1152
@pkra pkra added this to the ARIA 1.3 milestone Jan 11, 2022
@pkra pkra mentioned this pull request Jan 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charmarkk charmarkk charmarkk approved these changes

@carmacleod carmacleod carmacleod approved these changes

@cookiecrook cookiecrook cookiecrook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023
Development

Successfully merging this pull request may close these issues.

Missing definition: current element
5 participants
@pkra @cookiecrook @carmacleod @charmarkk @jnurthen