-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a conditional on when aria-controls is needed #1335
Conversation
Does it make sense to add an Implicit Value for Role? Maybe something like:
See the paragraph beginning with:
in the State and Property Attribute Processing section, which ends with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as-is, but would like an answer on whether or not adding Implicit value for role makes sense (or would just add more confusion).
Thanks @jnurthen !
Yeah - we nee
We have to do something - either add an implicit value or move to supported... Lets add to today's agenda and see what others think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR makes it more clear that aria-controls needs to be supported not required. If it is not present when the combobox is collapsed, the combobox would not validate.
+1 for the new state of this PR, which does 2 things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
resolves #1334
Preview | Diff