Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a conditional on when aria-controls is needed #1335

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Conversation

jnurthen
Copy link
Member

@jnurthen jnurthen commented Oct 7, 2020

resolves #1334


Preview | Diff

@carmacleod
Copy link
Contributor

carmacleod commented Oct 8, 2020

Does it make sense to add an Implicit Value for Role?

Maybe something like:

Implicit Value for Role: Default for aria-controls is undefined.

See the paragraph beginning with:

However, required states and properties that are absent are an author error.

in the State and Property Attribute Processing section, which ends with:

The characteristics table associated with each WAI-ARIA role has an " Implicit Value for Role " entry that specifies the value of a state or property to use in the context of that role when the state or property is missing.

Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as-is, but would like an answer on whether or not adding Implicit value for role makes sense (or would just add more confusion).
Thanks @jnurthen !

@jnurthen
Copy link
Member Author

jnurthen commented Oct 8, 2020

Yeah - we nee

Approving as-is, but would like an answer on whether or not adding Implicit value for role makes sense (or would just add more confusion).
Thanks @jnurthen !

We have to do something - either add an implicit value or move to supported... Lets add to today's agenda and see what others think.

@jnurthen jnurthen marked this pull request as draft October 8, 2020 17:15
@jnurthen jnurthen requested a review from mcking65 October 8, 2020 17:15
@jnurthen jnurthen marked this pull request as ready for review November 18, 2020 18:51
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes it more clear that aria-controls needs to be supported not required. If it is not present when the combobox is collapsed, the combobox would not validate.

@carmacleod
Copy link
Contributor

+1 for the new state of this PR, which does 2 things:

  • Adds "When the popup is displayed," so that the requirement for authors says the following:

    When the popup is displayed, authors MUST set aria-controls on a combobox element to a value that refers to the combobox popup element.

  • Moves aria-controls from required to supported in the characteristics table.

Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combobox shouldn't need aria-controls until the popup is rendered
5 participants