Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include SCT verification failure details in error message #3799

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented Jul 26, 2024

Summary

Fixes #3798 - this includes SCT verification failure details in error message, hence making it easier to debug the failure.

Release Note

Improved the error message that gets printed on SCT verification failure to include more specific details.

Documentation

I don't believe that this requires documentation, due to how small the change is.

@haydentherapper haydentherapper enabled auto-merge (squash) July 26, 2024 21:45
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 37.67%. Comparing base (2ef6022) to head (9bf0d93).
Report is 167 commits behind head on main.

Files Patch % Lines
pkg/cosign/verify_sct.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3799      +/-   ##
==========================================
- Coverage   40.10%   37.67%   -2.44%     
==========================================
  Files         155      201      +46     
  Lines       10044    12436    +2392     
==========================================
+ Hits         4028     4685     +657     
- Misses       5530     7175    +1645     
- Partials      486      576      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haydentherapper haydentherapper merged commit 62a2cff into sigstore:main Jul 26, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message for failed SCT verification
2 participants