Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COOP and COEP Implementation #5

Merged
merged 15 commits into from
Aug 11, 2020
Merged

COOP and COEP Implementation #5

merged 15 commits into from
Aug 11, 2020

Conversation

eozmen410
Copy link
Collaborator

No description provided.

salcho
salcho requested changes Jul 30, 2020
View reviewed changes
Copy link
Owner

@salcho salcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! simple and concise 💯 very minor comments

wicket-core/src/main/java/org/apache/wicket/coop/CoopConfiguration.java Outdated Show resolved Hide resolved
wicket-core/src/main/java/org/apache/wicket/coop/CoopConfiguration.java Outdated Show resolved Hide resolved
wicket-core/src/main/java/org/apache/wicket/coop/CoopConfiguration.java Show resolved Hide resolved
wicket-core/src/main/java/org/apache/wicket/coop/CoopConfiguration.java Outdated Show resolved Hide resolved
wicket-core/src/main/java/org/apache/wicket/coop/CoopConfiguration.java Outdated Show resolved Hide resolved
wicket-core/src/main/java/org/apache/wicket/coop/CoopRequestCycleListener.java Outdated Show resolved Hide resolved
@eozmen410 eozmen410 requested a review from salcho July 30, 2020 13:23
@eozmen410 eozmen410 changed the title Coop Implementation COOP and COEP Implementation Aug 4, 2020
@eozmen410 eozmen410 requested a review from salcho August 6, 2020 09:13
salcho
salcho requested changes Aug 7, 2020
View reviewed changes
Copy link
Owner

@salcho salcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! only a few comments around indentation

wicket-core/src/main/java/org/apache/wicket/coep/CoepRequestCycleListener.java Outdated Show resolved Hide resolved
wicket-core/src/main/java/org/apache/wicket/coep/CoepRequestCycleListener.java Outdated Show resolved Hide resolved
wicket-core/src/test/java/org/apache/wicket/coop/CoopRequestCycleListenerTest.java Outdated Show resolved Hide resolved
@eozmen410 eozmen410 requested a review from salcho August 7, 2020 09:28
salcho
salcho requested changes Aug 10, 2020
View reviewed changes
Copy link
Owner

@salcho salcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

wicket-core/src/main/java/org/apache/wicket/coop/CoopRequestCycleListener.java Outdated Show resolved Hide resolved
wicket-core/src/main/java/org/apache/wicket/coep/CoepRequestCycleListener.java Outdated Show resolved Hide resolved
wicket-core/src/main/java/org/apache/wicket/coop/CoopRequestCycleListener.java Outdated Show resolved Hide resolved
wicket-core/src/test/java/org/apache/wicket/coep/CoepRequestCycleListenerTest.java Outdated Show resolved Hide resolved
wicket-core/src/test/java/org/apache/wicket/coop/CoopRequestCycleListenerTest.java Outdated Show resolved Hide resolved
@eozmen410
Added tests for each COOP value, inlined url argument for checkHeader…
28ecd47 
…s in tests, formatted log statement to include path variable for exempted paths
@eozmen410 eozmen410 requested a review from salcho August 10, 2020 13:50
salcho
salcho approved these changes Aug 11, 2020
View reviewed changes
Copy link
Owner

@salcho salcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 💯

@eozmen410 eozmen410 merged commit 9e142dc into WICKET-6805 Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchatz22 gchatz22 gchatz22 left review comments

@salcho salcho salcho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eozmen410 @salcho @gchatz22