Add a try_reduce method to the Iterator trait
#87054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. Please see the contribution instructions for more information. |
3 tasks
This comment has been minimized.
This comment has been minimized.
the8472
reviewed
Jul 11, 2021
scottmcm
reviewed
Sep 1, 2021
scottmcm
reviewed
Sep 1, 2021
|
☔ The latest upstream changes (presumably #89158) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Triage: there's merge conflict now. Would you mind rebasing it? @kit-981 |
Thanks. I've updated the pull request. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 3, 2021
Make `array::{try_from_fn, try_map}` and `Iterator::try_find` generic over `Try`
Fixes rust-lang#85115
This only updates unstable functions.
`array::try_map` didn't actually exist before; this adds it under the still-open tracking issue rust-lang#79711 from the old PR rust-lang#79713.
Tracking issue for the new trait: rust-lang#91285
This would also solve the return type question in for the proposed `Iterator::try_reduce` in rust-lang#87054
This comment has been minimized.
This comment has been minimized.
scottmcm
reviewed
Dec 4, 2021
|
Thanks for the PR! Sorry it took 5 months 😬 @bors r+ |
|
📌 Commit aef59e4 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2021
…askrgr Rollup of 3 pull requests Successful merges: - rust-lang#87054 (Add a `try_reduce` method to the Iterator trait) - rust-lang#89701 (Updated error message for accidental uses of derive attribute as a crate attribute) - rust-lang#90519 (Keep spans for generics in `#[derive(_)]` desugaring) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #87053