give full path of constraint in suggest_constraining_type_param

[Rustin170506]

close #83513

[rust-highfive]

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

[lcnr]

r? @estebank

feeling unsure about whether using full paths is actually desirable, but don't have a strong opinion here

[estebank]

Oh! It's a shame that it also affects things in the prelude 🤔

The current behavior means you get two errors but if you apply both suggestions you get to working code. The new behavior means a single step to working code, at the cost of verbosity.

@lcnr what do you think about this: lets land this (to reduce fix cycles for users) and revisit this output once we have real "locally accessible paths" for these suggestions where we can reduce the verbosity again.

[lcnr]

what do you think about this: lets land this (to reduce fix cycles for users) and revisit this output once we have real "locally accessible paths" for these suggestions where we can reduce the verbosity again.

👍

[estebank]

@bors r+

[bors]

📌 Commit 1f3d049 has been approved by estebank

[Dylan-DPC-zz]

failed in rollup

@bors r-

[Rustin170506]

failed in rollup

@bors r-

failed in rollup

@bors r-

@Dylan-DPC Blessed with nll compare mode.

[Rustin170506]

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

[Dylan-DPC-zz]

@bors r=estebank

[bors]

📌 Commit 8f77356 has been approved by estebank

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[Dylan-DPC-zz]

failed in rollup

@bors r-

[Rustin170506]

failed in rollup

@bors r-

@Dylan-DPC I tested both modes again locally with no problems, so I don't know what's wrong, do you have any suggestions?

[Rustin170506]

It seems that without my commit, this #83728 PR is also failing because of the same problem?

[Rustin170506]

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

[Dylan-DPC-zz]

let's give it a try once,

@bors r=estebank

[bors]

📌 Commit 8f77356 has been approved by estebank

[Rustin170506]

let's give it a try once,

Thanks, maybe we can rollup this time without the other PRs that modify the diagnostic information, otherwise it might fail again and we still don't know if the PR is the problem.