Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in test "mem::uninit_write_slice_cloned_no_drop" #80123

Merged
merged 2 commits into from
Dec 20, 2020
Merged

Fix memory leak in test "mem::uninit_write_slice_cloned_no_drop" #80123

merged 2 commits into from
Dec 20, 2020

Conversation

beepster4096
Copy link
Contributor

This fixes #80116. I replaced the Rc based method I was using with a type that panics when dropped.

@rust-highfive
Copy link
Collaborator

r? @shepmaster

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2020
@RalfJung
Copy link
Member

Thanks! I almost missed this PR; feel free to post a message in the issue when a PR fixes the issue so people are aware and can do the reviewing. :)

r? @RalfJung
@bors r+ rollup

@rust-highfive rust-highfive assigned RalfJung and unassigned shepmaster Dec 18, 2020
@bors
Copy link
Contributor

bors commented Dec 18, 2020

📌 Commit 01f36c5 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Dec 18, 2020
@RalfJung
Rollup merge of rust-lang#80123 - DrMeepster:maybe_uninit_write_slice…
4a8f870 
…, r=RalfJung

Fix memory leak in test "mem::uninit_write_slice_cloned_no_drop"

This fixes rust-lang#80116. I replaced the `Rc` based method I was using with a type that panics when dropped.
@RalfJung RalfJung mentioned this pull request Dec 18, 2020
Closed
@RalfJung
Copy link
Member

@bors r-

Failed on a wasm target:

error: unused import: `std::rc::Rc`
 --> library/core/tests/mem.rs:3:5
  |
3 | use std::rc::Rc;
  |     ^^^^^^^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 18, 2020
@beepster4096
Copy link
Contributor Author

beepster4096 commented Dec 18, 2020 •
edited
Loading

Fixed that error

@RalfJung
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 19, 2020

📌 Commit 28e0d2f has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 19, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 20, 2020
@Dylan-DPC
Rollup merge of rust-lang#80123 - DrMeepster:maybe_uninit_write_slice…
9fdd80c 
…, r=RalfJung

Fix memory leak in test "mem::uninit_write_slice_cloned_no_drop"

This fixes rust-lang#80116. I replaced the `Rc` based method I was using with a type that panics when dropped.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 20, 2020
@Dylan-DPC
Rollup merge of rust-lang#80123 - DrMeepster:maybe_uninit_write_slice…
9d5280a 
…, r=RalfJung

Fix memory leak in test "mem::uninit_write_slice_cloned_no_drop"

This fixes rust-lang#80116. I replaced the `Rc` based method I was using with a type that panics when dropped.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 20, 2020
Closed
@bors
Copy link
Contributor

bors commented Dec 20, 2020

⌛ Testing commit 28e0d2f with merge 59aaa2a...

@bors
Copy link
Contributor

bors commented Dec 20, 2020

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 59aaa2a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 20, 2020
@bors bors merged commit 59aaa2a into rust-lang:master Dec 20, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RalfJung RalfJung

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.

Test "mem::uninit_write_slice_cloned_no_drop" leaks memory
6 participants
@beepster4096 @rust-highfive @RalfJung @bors @shepmaster @rustbot