Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend Ty and TyCtxt lints to self types #76914

Merged
merged 4 commits into from
Sep 22, 2020
Merged

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Sep 19, 2020

blocked on #76891

r? @ecstatic-morse cc @Aaron1011

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2020
@ecstatic-morse
Copy link
Contributor

ecstatic-morse commented Sep 19, 2020

LGTM. We actually have a test for this internal lint: grep for &TyCtxt. r=me when that is updated.

@lcnr
Copy link
Contributor Author

lcnr commented Sep 19, 2020

We need to add in inherent impl for TyCtxt for this update to matter, as we don't lint for trait impls.

So the only solution I see here is to add a new struct with #[rustc_diagnostic_item = "TyCtxt"] which seemed weird to me.
If you think this is worth it I will go ahead and add it.

@ecstatic-morse
Copy link
Contributor

ecstatic-morse commented Sep 19, 2020

Ah yes, that's right. Do we even allow for colliding diagnostic impls I wonder? I would like to test this: could you try once with #[rustc_diagnostic_item]? If it breaks we can just merge as-is.

@lcnr
Copy link
Contributor Author

lcnr commented Sep 21, 2020

added a test, the changes don't make too much sense for Ty as we would need to use custom self types 🤷 added a comment for this.

@ecstatic-morse
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 22, 2020

📌 Commit 8fc782a has been approved by ecstatic-morse

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2020
ecstatic-morse added a commit to ecstatic-morse/rust that referenced this pull request Sep 22, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2020
…atic-morse

Rollup of 13 pull requests

Successful merges:

 - rust-lang#72734 (Reduce duplicate in liballoc reserve error handling)
 - rust-lang#76131 (Don't use `zip` to compare iterators during pretty-print hack)
 - rust-lang#76150 (Don't recommend ManuallyDrop to customize drop order)
 - rust-lang#76275 (Implementation of Write for some immutable ref structs)
 - rust-lang#76489 (Add explanation for E0756)
 - rust-lang#76581 (do not ICE on bound variables, return `TooGeneric` instead)
 - rust-lang#76655 (Make some methods of `Pin` unstable const)
 - rust-lang#76783 (Only get ImplKind::Impl once)
 - rust-lang#76807 (Use const-checking to forbid use of unstable features in const-stable functions)
 - rust-lang#76888 (use if let instead of single match arm expressions)
 - rust-lang#76914 (extend `Ty` and `TyCtxt` lints to self types)
 - rust-lang#77022 (Reduce boilerplate for BytePos and CharPos)
 - rust-lang#77032 (lint missing docs for extern items)

Failed merges:

r? `@ghost`
@bors bors merged commit 50d4aeb into rust-lang:master Sep 22, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 22, 2020
@lcnr lcnr deleted the path-no-more branch September 22, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants