Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point towards format_spec; it is in other direction #74819

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jul 27, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2020
@bors
Copy link
Contributor

bors commented Jul 28, 2020

☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts.

@@ -83,7 +83,7 @@
//! # Formatting Parameters
//!
//! Each argument being formatted can be transformed by a number of formatting
//! parameters (corresponding to `format_spec` in the syntax above). These
//! parameters (corresponding to `format_spec` in the syntax below). These
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to link to an anchor on the same page? If so, how about changing this to just "syntax" and linking it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggestion, replaced with a link to the syntax anchor.

Copy link
Member

@joshtriplett joshtriplett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made one comment for potential improvement. If that improvement is possible, r=me with that included. If it isn't possible, then r=me for this change.

@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 29, 2020

📌 Commit 1b4a6a5 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2020
…arth

Rollup of 10 pull requests

Successful merges:

 - rust-lang#74742 (Remove links to rejected errata 4406 for RFC 4291)
 - rust-lang#74819 (Point towards `format_spec`; it is in other direction)
 - rust-lang#74852 (Explain why inlining default ToString impl)
 - rust-lang#74869 (Make closures and generators a must use types)
 - rust-lang#74873 (symbol mangling: use ty::print::Print for consts)
 - rust-lang#74902 (Remove deprecated unstable `{Box,Rc,Arc}::into_raw_non_null` functions)
 - rust-lang#74904 (Fix some typos in src/librustdoc/clean/auto_trait.rs)
 - rust-lang#74910 (fence docs: fix example Mutex)
 - rust-lang#74912 (Fix broken link in unstable book `plugin`)
 - rust-lang#74927 (Change the target data layout to specify more values)

Failed merges:

r? @ghost
@bors bors merged commit 3522676 into rust-lang:master Jul 30, 2020
@tmiasko tmiasko deleted the format-spec branch July 30, 2020 02:13
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants