Move treat err as bug tests to ui #71531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
spastorino
commented
Apr 24, 2020
|
The main doubt I have about this PR is if we should run it with |
3f8aab3
to
7b9aea4
Compare
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
I'm not sure how to make or ui test not care about stderr files, or the right flags to generate the same stacktrace everywhere or a way to run compile-tests that allow 101 exit codes. cc @oli-obk |
We should not run it with backtrace, as that will break the test with every tiny change to rustc. While we could probably mitigate that with stderr normalization patterns, it would still just be noise to all PRs that cause a change to the backtrace. |
@oli-obk yes, it is not great to run with backtrace in my opinion but on the other hand, how do you test that this is stopping in the right place?. What I wanted was something that runs with backtraces on but filter those out and just search for ... or something like that. that breaks if Thoughts? |
|
I'm not sure if stderr normalization can do this, but if you can remove entire lines, you can remove all the |
7b9aea4
to
8ea5ae4
Compare
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
oli-obk
reviewed
Apr 27, 2020
|
r? @oli-obk -- I agree with the sentiment that we don't want this test to break constantly =) but the idea of testing backtrace makes sense. |
|
@oli-obk @nikomatsakis: @eddyb had a better idea which is to implement what's stated in #70953. After that's implemented, in this PR, we can reuse the new generated output and more properly test by using instead of the backtrace, just the query stack. Besides from the idea being a good one per se, it would make these tests better too :) and we would avoid all these kind of tricks we were mentioning. So I'd say that this PR is blocked on #70953. |
|
☔ The latest upstream changes (presumably #71636) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Just in case to be clear, this is blocked on #70953. |
8ea5ae4
to
fa84a9e
Compare
fa84a9e
to
1aa8b04
Compare
|
This is now ready to review. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
e5e9046
to
5a2c4c4
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
0e0fa06
to
832cf54
Compare
832cf54
to
96dbe32
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
96dbe32
to
6d9efd1
Compare
|
@bors r+ rollup |
|
📌 Commit 6d9efd1 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#71531 (Move treat err as bug tests to ui) - rust-lang#81356 (libtest: allow multiple filters) - rust-lang#81735 (faster few span methods) - rust-lang#81779 (improve error message for disallowed ptr-to-int casts in const eval) - rust-lang#81817 (Add option to emit compiler stderr per bitwidth.) - rust-lang#81828 (parse_format: treat r" as a literal) - rust-lang#81840 (fix formatting of std::iter::Map) - rust-lang#81861 (Show MIR bytes separately in -Zmeta-stats output) - rust-lang#81865 (Clean up weird Option mapping) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @oli-obk