Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow the same function order in the trait #66779

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

guanqun
Copy link
Contributor

@guanqun guanqun commented Nov 26, 2019

With this change, the function order in both traits and implementation matches.

And this fix removes several warnings in IDE.

This removes several warnings in IDE.
@rust-highfive
Copy link
Collaborator

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2019
@hellow554
Copy link
Contributor

And this fix removes several warnings in IDE.

can you elaborate that?

@Dylan-DPC-zz
Copy link

Thanks

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 26, 2019

📌 Commit 55d7258 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Nov 26, 2019
follow the same function order in the trait

With this change, the function order in both traits and implementation matches.

And this fix removes several warnings in IDE.
bors added a commit that referenced this pull request Nov 27, 2019
Rollup of 14 pull requests

Successful merges:

 - #66128 (alloc: Add new_zeroed() versions like new_uninit().)
 - #66661 (Add riscv64gc-unknown-linux-gnu target)
 - #66663 (Miri: print leak report even without tracing)
 - #66711 (Add hardware floating point features to aarch64-pc-windows-msvc)
 - #66713 (introduce a target to build the kernel of the unikernel HermitCore)
 - #66717 (tidy: Accommodate rustfmt's preferred layout of stability attributes)
 - #66719 (Store pointer width as u32 on Config)
 - #66720 (Move ErrorReported to rustc_errors)
 - #66737 (Error codes cleanup)
 - #66754 (Various tweaks to diagnostic output)
 - #66763 (Minor edit for documentation-tests.md that increases clarity)
 - #66779 (follow the same function order in the trait)
 - #66786 (Add wildcard test for const_if_match)
 - #66788 (Allow `Unreachable` terminators through `min_const_fn` checks)

Failed merges:

r? @ghost
@bors bors merged commit 55d7258 into rust-lang:master Nov 27, 2019
@guanqun
Copy link
Contributor Author

guanqun commented Nov 27, 2019

And this fix removes several warnings in IDE.

can you elaborate that?

This fixes several warnings in CLion with Rust plugin installed.

@guanqun guanqun deleted the reorder-funcs branch November 27, 2019 09:09
@hellow554
Copy link
Contributor

This fixes several warnings in CLion with Rust plugin installed.

with elabrorate I mean, explain please what kind of warnings the plugin gives you.

@guanqun
Copy link
Contributor Author

guanqun commented Nov 27, 2019

This fixes several warnings in CLion with Rust plugin installed.

with elabrorate I mean, explain please what kind of warnings the plugin gives you.

I can't remember the exact warning messages, but it's roughly about "the function order doesn't match the order declared in the traits".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants