in which we suggest anonymizing single-use lifetimes in paths #62453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niko Matsakis commented in October 2017 (rust-lang#44752 (comment)) that these should lint. They do! Let's reify that in the tests now (and then we'll see a nice diff when we add suggestions in a future commit).
eddyb
reviewed
Jul 11, 2019
| | | ||
| LL | fn left<'x, 'y>(foo: Double<'x, 'y>) -> &'x u32 { foo.f } | ||
| | ^^ this lifetime... -- ...is used only here | ||
| help: elide the single-use lifetime |
There was a problem hiding this comment.
Can you perhaps add a rustfix test? I assume this suggestion can be automatically applied, yes?
There was a problem hiding this comment.
I think it can't due to the multiple ambiguity span bug, unless that has been fixed since Berlin.
estebank
reviewed
Jul 12, 2019
| (Some(decl_span), Some(use_span), None) => { | ||
| // if both declaration and use deletion spans start at the same | ||
| // place ("start at" because the latter includes trailing | ||
| // whitespace), then this is an in-band lifetime |
There was a problem hiding this comment.
This sounds like a bug in the ast's span, right? No need to fix now but add a FIXME
There was a problem hiding this comment.
No, that's not referring to an AST span; it's referring to a span that we synthesized earlier in the function (the 'a with the trailing space in &'a Foo).
|
@bors r+ rollup |
|
📌 Commit acc4e56 has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 12, 2019
in which we suggest anonymizing single-use lifetimes in paths Following @nikomatsakis's [October 2017 comment](rust-lang#44752 (comment)).  r? @estebank cc @eddyb (you were saying something about running single-use-lifetimes against the tree the other week?)
8 tasks
bors
added a commit
that referenced
this pull request
Jul 12, 2019
Rollup of 12 pull requests Successful merges: - #61535 (Coherence test when a generic type param has a default value from an associated type) - #62274 (rustc_mir: follow FalseUnwind's real_target edge in qualify_consts.) - #62431 (Add messages to `Option`'s and `Result`'s `must_use` annotation for `is_*`) - #62453 (in which we suggest anonymizing single-use lifetimes in paths ) - #62568 (Replace unsafe_destructor_blind_to_params with may_dangle) - #62578 (Add test for #49919) - #62595 (Document that the crate keyword refers to the project root) - #62599 (move mem::uninitialized deprecation back by 1 release, to 1.39) - #62605 (Emit dropped unemitted errors to aid in ICE debugging) - #62607 (Correctly break out of recovery loop) - #62608 (`async unsafe fn` tests) - #62623 (downgrade indirect_structural_match lint to allow) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @nikomatsakis's October 2017 comment.
r? @estebank
cc @eddyb (you were saying something about running single-use-lifetimes against the tree the other week?)