add coherence future-compat warnings for marker-only trait objects #56481

arielb1 · 2018-12-03T21:25:45Z

The future-compat warnings break code that assumes that dyn Send + Sync != dyn Sync + Send, and are the first step in making them equal. cc #33140.

Note: this lint should be made to default-warn before we merge. It is deny only for the crater run.

r? @nikomatsakis / @scalexm . cc @Centril & @alexreg.

arielb1 · 2018-12-03T21:28:29Z

A crater run would be nice. cc @Mark-Simulacrum ?

arielb1 · 2018-12-03T21:29:35Z

@rust-lang/infra Could we get a crater run on this branch? check-only should be fine - I just want to see when my lint will fire.

pietroalbini · 2018-12-03T21:38:47Z

@bors try

pietroalbini · 2018-12-03T21:41:06Z

@bors are you still there?

bors · 2018-12-03T21:41:08Z

🍰 Target acquired

pietroalbini · 2018-12-03T21:41:18Z

@bors try please

bors · 2018-12-03T21:41:49Z

⌛ Trying commit e24cd91 with merge cd9f7376b6b24f6a277b46070935c4cb83606e90...

src/test/run-pass/issues/issue-33140.rs

rust-highfive · 2018-12-03T22:17:53Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:21a30df0:start=1543872582394817813,finish=1543872650770012180,duration=68375194367
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:44:12] .................................................................................................... 200/5106
[00:44:14] .................................................................................................... 300/5106
[00:44:17] .................................................................................................... 400/5106
[00:44:20] .................................................................................................... 500/5106
[00:44:23] .....................F.......Fi......................................F...F..F....................... 600/5106
[00:44:32] ..................................................................................................i. 800/5106
[00:44:36] ..............i..................................................................................... 900/5106
[00:44:39] .....................iiiii.......................................................................... 1000/5106
[00:44:42] .................................................................................................... 1100/5106
---
[00:46:26] .................................................................................................... 4400/5106
[00:46:29] .................................................................................................... 4500/5106
[00:46:32] .................................................................................................... 4600/5106
[00:46:36] .....................................................................i.............................. 4700/5106
[00:46:39] ...............F.................................................................................... 4800/5106
[00:46:45] .................................................................................................... 5000/5106
ools/compiletest/src/main.rs:503:22
ools/compiletest/src/main.rs:503:22
[00:46:48] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[00:46:48] ------------------------------------------
[00:46:48] 
[00:46:48] thread '[ui] ui/codemap_tests/coherence-overlapping-inherent-impl-trait.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3282:9
[00:46:48] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:46:48] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:46:48] 
[00:46:48] ---- [ui] ui/codemap_tests/overlapping_inherent_impls.rs stdout ----
[00:46:48] diff of stderr:
[00:46:48] 
[00:46:48] - error[E0592]: duplicate definitions with name `id`
[00:46:48] + error: duplicate definitions with name `id` (E0592)
[00:46:48] 2   --> $DIR/overlapping_inherent_impls.rs:19:5
[00:46:48] 3    |
[00:46:48] 4 LL |     fn id() {} //~ ERROR duplicate definitions
[00:46:48] 6 ...
[00:46:48] 6 ...
[00:46:48] 7 LL |     fn id() {}
[00:46:48] 8    |     ---------- other definition for `id`
[00:46:48] +    = note: #[deny(incoherent_fundamental_impls)] on by default
[00:46:48] +    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[00:46:48] +    = note: for more information, see issue #46205 <https://github.com/rust-lang/rust/issues/46205>
[00:46:48] 9 
[00:46:48] 9 
[00:46:48] - error[E0592]: duplicate definitions with name `bar`
[00:46:48] + error: duplicate definitions with name `bar` (E0592)
[00:46:48] 11   --> $DIR/overlapping_inherent_impls.rs:29:5
[00:46:48] 12    |
[00:46:48] 13 LL |     fx86_64-unknown-linux-gnu/test/ui/codemap_tests/overlapping_inherent_impls/overlapping_inherent_impls.stderr
[00:46:48] To update references, rerun the tests and pass the `--bless` flag
[00:46:48] To only update this specific test, also pass `--test-args codemap_tests/overlapping_inherent_impls.rs`
[00:46:48] error: 1 errors occurred comparing output.
[00:46:48] status: exit code: 1
[00:46:48] status: exit code: 1
[00:46:48] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/codemap_tests/overlapping_inherent_impls.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/codemap_tests/overlapping_inherent_impls/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/codemap_tests/overlapping_inherent_impls/auxiliary" "-A" "unused"
[00:46:48] ------------------------------------------
[00:46:48] 
[00:46:48] ------------------------------------------
[00:46:48] stderr:
[00:46:48] stderr:
[00:46:48] ------------------------------------------
[00:46:48] {"message":"duplicate definitions with name `id` (E0592)","code":{"code":"incoherent_fundamental_impls","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/codemap_tests/overlapping_inherent_impls.rs","byte_start":611,"byte_end":621,"line_start":19,"line_end":19,"column_start":5,"column_end":15,"is_primary":true,"text":[{"text":"    fn id() {} //~ ERROR duplicate definitions","highlight_start":ll,"level":"note","spans":[],"children":[],"rendered":null},{"message":"upstream crates may add new impl of trait `std::marker::Copy` for type `std::vec::Vec<_>` in future versions","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: duplicate definitions with name `baz` (E0592)\n  --> /checkout/src/test/ui/codemap_tests/overlapping_inherent_impls.rs:39:5\n   |\nLL |     fn baz(&self) {} //~ ERROR duplicate definitions\n   |     ^^^^^^^^^^^^^^^^ duplicate definitions for `baz`\n...\nLL |     fn baz(&self) {}\n   |     ---------------- other definition for `baz`\n   |\n   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!\n   = note: for more information, see issue #46205 <https://github.com/rust-lang/rust/issues/46205>\n   = note: upstream crates may add new impl of trait `std::marker::Copy` for type `std::vec::Vec<_>` in future versions\n\n"}
[00:46:48] {"message":"aborting due to 3 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 3 previous errors\n\n"}
[00:46:48] ------------------------------------------
[00:46:48] 
[00:46:48] thread '[ui] ui/codemap_tests/overlapping_inherent_impls.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3282:9
[00:46:48] 
[00:46:48] 
[00:46:48] ---- [ui] ui/coherence/coherence-overlap-downstream-inherent.rs stdout ----
[00:46:48] diff of stderr:
[00:46:48] 
[00:46:48] - error[E0592]: duplicate definitions with name `dummy`
[00:46:48] + error: duplicate definitions with name `dummy` (E0592)
[00:46:48] 2   --> $DIR/coherence-overlap-downstream-inherent.rs:17:26
[00:46:48] 3    |
[00:46:48] 4 LL | impl<T:Sugar> Sweet<T> { fn dummy(&self) { } }
[00:46:48] 
[00:46:48] 6 LL | //~^ ERROR E0592
[00:46:48] 7 LL | impl<T:Fruit> Sweet<T> { fn dummy(&self) { } }
[00:46:48] 8    |                          ------------------- other definition for `dummy`
[00:46:48] +    = note: #[deny(incoherent_fundamental_impls)] on by default
[00:46:48] +    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[00:46:48] +    = note: for more information, see issue #46205 <https://github.com/rust-lang/rust/issues/46205>
[00:46:48] 9 
[00:46:48] 9 
[00:46:48] - error[E0592]: duplicate definitions with name `f`
[00:46:48] + error: duplicate definitions with name `f` (E0592)
[00:46:48] 11   --> $DIR/coherence-overlap-downstream-inherent.rs:23:38
[00:46:48] 12    |
[00:46:48] 13 LL | impl<X, T> A<T, X> where T: Bar<X> { fn f(&self) {} }
[00:46:48] 
[00:46:48] 16 LL | impl<X> A<i32, X> { fn f(&self) {} }
[00:46:48] 17    |                     -------------- other definition for `f`
[00:46:48] +    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[00:46:48] +    = note: for more information, see issue #46205 <https://github.com/rust-lang/rust/issues/46205>
[00:46:48] +    = note: for more information, see issue #46205 <https://github.com/rust-lang/rust/issues/46205>
[00:46:48] 19    = note: downstream crates may implement trait `Bar<_>` for type `i32`
[00:46:48] 21 error: aborting due to 2 previous errors
[00:46:48] 
[00:46:48] 22 
[00:46:48] - For more information about this error, try `rustc --explain E0592`.
[00:46:48] - For more information about this error, try `rustc --explain E0592`.
[00:46:48] 24 
[00:46:48] 
[00:46:48] 
[00:46:48] The actual stderr differed from the expected stderr.
[00:46:48] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/coherence/coherence-overlap-downstream-inherent/coherence-overlap-downstream-inherent.stderr
[00:46:48] To update references, rerun the tests and pass the `--bless` flag
[00:46:48] To only update this specific test, also pass `--test-args coherence/coherence-overlap-downstream-inherent.rs`
[00:46:48] error: 1 errors occurred comparing output.
[00:46:48] status: exit code: 1
[00:46:48] status: exit code: 1
[00:46:48] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/coherence/coherence-overlap-downstream-inherent.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/coherence/coherence-overlap-downstream-inherent/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/coherence/coherence-overlap-downstream-inherent/auxiliary" "-A" "unused"
[00:46:48] ------------------------------------------
[00:46:48] 
[00:46:48] ------------------------------------------
[00:46:48] stderr:
[00:46:48] stderr:
[00:46:48] ------------------------------------------
[00:46:48] {"message":"duplicate definitions with name `dummy` (E0592)","code":{"code":"incoherent_fundamental_impls","explanation":null},"level":"error = note: for more information, see issue #46205 <https://github.com/rust-lang/rust/issues/46205>\n   = note: downstream crates may implement trait `Sugar` for type `std::boxed::Box<_>`\n\n"}
[00:46:48] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[00:46:48] ------------------------------------------
[00:46:48] 
[00:46:48] thread '[ui] ui/coherence/coherence-overlap-issue-23516-inherent.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3282:9
[00:46:48] 
[00:46:48] 
[00:46:48] ---- [ui] ui/coherence/coherence-overlap-upstream-inherent.rs stdout ----
[00:46:48] diff of stderr:
[00:46:48] 
[00:46:48] - error[E0592]: duplicate definitions with name `dummy`
[00:46:48] + error: duplicate definitions with name `dummy` (E0592)
[00:46:48] 2   --> $DIR/coherence-overlap-upstream-inherent.rs:21:32
[00:46:48] 3    |
[00:46:48] 4 LL | impl<T> A<T> where T: Remote { fn dummy(&self) { } }
[00:46:48] 
[00:46:48] 7 LL | impl A<i16> { fn dummy(&self) { } }
[00:46:48] 8    |               ------------------- other definition for `dummy`
[00:46:48] +    = note: #[deny(incoherent_fundamental_impls)] on by default
[00:46:48] +    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[00:46:48] +    = note: for more information, see issue #46205 <https://github.com/rust-lang/rust/issues/46205>
[00:46:48] +    = note: for more information, see issue #46205 <https://github.com/rust-lang/rust/issues/46205>
[00:46:48] 10    = note: upstream crates may add new impl of trait `coherence_lib::Remote` for type `i16` in future sts/coherence-overlapping-inherent-impl-trait.rs
[00:46:48]     [ui] ui/coherence/coherence-overlap-downstream-inherent.rs
[00:46:48]     [ui] ui/coherence/coherence-overlap-issue-23516-inherent.rs
[00:46:48]     [ui] ui/coherence/coherence-overlap-upstream-inherent.rs
[00:46:48]     [ui] ui/traits/trait-object-auto-dedup-in-impl.rs
[00:46:48]     [ui] ui/traits/trait-object-auto-dedup-in-impl.rs
[00:46:48] 
[00:46:48] test result: FAILED. 5076 passed; 6 failed; 24 ignored; 0 measured; 0 filtered out
[00:46:48] 
[00:46:48] 
[00:46:48] 
[00:46:48] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

arielb1 · 2018-12-03T22:38:53Z

please don't try this until travis is green!

kennytm · 2018-12-04T02:22:57Z

@bors try

bors · 2018-12-04T02:23:09Z

⌛ Trying commit 35919bd with merge 1df9798...

@nikomatsakis

add coherence future-compat warnings for marker-only trait objects The future-compat warnings break code that assumes that `dyn Send + Sync != dyn Sync + Send`, and are the first step in making them equal. cc #33140. Note: this lint should be made to default-warn before we merge. It is deny only for the crater run. r? @nikomatsakis / @scalexm . cc @Centril & @alexreg.

bors · 2018-12-04T04:42:15Z

☀️ Test successful - status-travis
State: approved= try=True

kennytm · 2018-12-04T05:53:01Z

@craterbot run start=master#c8ae2de8363be088604ffa2ccba84ff7ad7250bc end=try#1df97983eb2057dc6a8f7eb364e263b51ae23230 mode=check-only

craterbot · 2018-12-04T05:53:03Z

👌 Experiment pr-56481 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2018-12-04T05:53:04Z

🚧 Experiment pr-56481 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2018-12-05T17:50:22Z

🎉 Experiment pr-56481 is completed!
📊 2 regressed and 0 fixed (48742 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

nikomatsakis · 2018-12-13T20:15:39Z

@rust-lang/lang meeting says -- seems like we should clearly go forward.

The future-compat warnings break code that assumes that `dyn Send + Sync != dyn Sync + Send`, and are the first step in making them equal. cc rust-lang#33140. It should be possible to revert this commit when we're done with the warnings.

arielb1 · 2018-12-14T17:25:38Z

rebased. However, should we just directly go to an hard error?

nikomatsakis · 2018-12-17T21:03:05Z

@bors r+

bors · 2018-12-17T21:03:06Z

📌 Commit f934cfc has been approved by nikomatsakis

nikomatsakis · 2018-12-17T21:03:40Z

I guess for now we can land this version, it'd be nice to do at least a short warning period, though I'd definitely like to land #56837 ASAP

bors · 2018-12-18T06:50:21Z

⌛ Testing commit f934cfc with merge 041254b...

@nikomatsakis

add coherence future-compat warnings for marker-only trait objects The future-compat warnings break code that assumes that `dyn Send + Sync != dyn Sync + Send`, and are the first step in making them equal. cc #33140. Note: this lint should be made to default-warn before we merge. It is deny only for the crater run. r? @nikomatsakis / @scalexm . cc @Centril & @alexreg.

bors · 2018-12-18T09:22:30Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 041254b to master...

cc rust-lang/rust#56481.

Centril · 2018-12-21T18:44:35Z

It seems we went for deny-by-default here instead of warn; was that intentional? cc @nikomatsakis

arielb1 · 2018-12-21T18:48:31Z

It wasn't intentional - I forgot to change it to warn after I made a crater run. However, I think the only affected crate is traitobject, so I think this is OK.

Centril · 2018-12-21T18:55:09Z

@arielb1 My concern isn't so much traitobject as the reverse dependencies it has (see #55994 (comment) ...). Ideally we'd like to get a patch release of traitobject ASAP but we haven't been able to reach @reem yet.

arielb1 · 2018-12-21T19:01:12Z

Having a deny-by-default lint shouldn't affect reverse dependencies.

alexreg · 2018-12-21T20:59:23Z

@arielb1 Okay. Should I change it to warn-by-default anyway?

@nikomatsakis

…akis Add support for trait-objects without a principal The hard-error version of #56481 - should be merged after we do something about the `traitobject` crate. Fixes #33140. Fixes #57057. r? @nikomatsakis

rust-highfive assigned nikomatsakis Dec 3, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2018

arielb1 force-pushed the dynamic-order branch from 59fde36 to e24cd91 Compare December 3, 2018 21:28

arielb1 added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Dec 3, 2018

Centril reviewed Dec 3, 2018

View reviewed changes

src/test/run-pass/issues/issue-33140.rs Show resolved Hide resolved

arielb1 mentioned this pull request Dec 3, 2018

Tracking issue for future-incompatbility lint order_dependent_trait_objects #56484

Open

Centril added I-nominated T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Dec 3, 2018

arielb1 force-pushed the dynamic-order branch from 49128bc to 35919bd Compare December 3, 2018 23:41

craterbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2018

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 5, 2018

Centril removed the I-nominated label Dec 13, 2018

arielb1 added 4 commits December 14, 2018 18:19

add the ORDER_DEPENDENT_TRAIT_OBJECTS lint

3882567

fix stupid bug

6e4b2b3

use tracking issue instead of original issue

c2ba2a7

arielb1 force-pushed the dynamic-order branch from 35919bd to c2ba2a7 Compare December 14, 2018 17:17

fix english

f934cfc

arielb1 mentioned this pull request Dec 15, 2018

Add support for trait-objects without a principal #56837

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2018

bors merged commit f934cfc into rust-lang:master Dec 18, 2018

topecongiro added a commit to topecongiro/rust-semverver that referenced this pull request Dec 19, 2018

Fix build in nightly

f8fab65

cc rust-lang/rust#56481.

topecongiro mentioned this pull request Dec 19, 2018

Fix build in nightly rust-lang/rust-semverver#82

Merged

hdhoang mentioned this pull request Dec 24, 2018

lint: convert incoherent_fundamental_impls into hard error #49799

Merged

nagisa mentioned this pull request Jan 3, 2019

ICE instead of coherence error #57162

Closed

withoutboats mentioned this pull request Feb 1, 2019

Tracking issue for trait aliases #41517

Open

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add coherence future-compat warnings for marker-only trait objects #56481

add coherence future-compat warnings for marker-only trait objects #56481

arielb1 commented Dec 3, 2018 •

edited

Loading

arielb1 commented Dec 3, 2018

arielb1 commented Dec 3, 2018

pietroalbini commented Dec 3, 2018

pietroalbini commented Dec 3, 2018

bors commented Dec 3, 2018

pietroalbini commented Dec 3, 2018

bors commented Dec 3, 2018

rust-highfive commented Dec 3, 2018

arielb1 commented Dec 3, 2018

kennytm commented Dec 4, 2018

bors commented Dec 4, 2018

bors commented Dec 4, 2018

kennytm commented Dec 4, 2018

craterbot commented Dec 4, 2018

craterbot commented Dec 4, 2018

craterbot commented Dec 5, 2018

nikomatsakis commented Dec 13, 2018 •

edited

Loading

arielb1 commented Dec 14, 2018

nikomatsakis commented Dec 17, 2018

bors commented Dec 17, 2018

nikomatsakis commented Dec 17, 2018

bors commented Dec 18, 2018

bors commented Dec 18, 2018

Centril commented Dec 21, 2018

arielb1 commented Dec 21, 2018 •

edited

Loading

Centril commented Dec 21, 2018

arielb1 commented Dec 21, 2018

alexreg commented Dec 21, 2018

add coherence future-compat warnings for marker-only trait objects #56481

add coherence future-compat warnings for marker-only trait objects #56481

Conversation

arielb1 commented Dec 3, 2018 • edited Loading

arielb1 commented Dec 3, 2018

arielb1 commented Dec 3, 2018

pietroalbini commented Dec 3, 2018

pietroalbini commented Dec 3, 2018

bors commented Dec 3, 2018

pietroalbini commented Dec 3, 2018

bors commented Dec 3, 2018

rust-highfive commented Dec 3, 2018

arielb1 commented Dec 3, 2018

kennytm commented Dec 4, 2018

bors commented Dec 4, 2018

bors commented Dec 4, 2018

kennytm commented Dec 4, 2018

craterbot commented Dec 4, 2018

craterbot commented Dec 4, 2018

craterbot commented Dec 5, 2018

nikomatsakis commented Dec 13, 2018 • edited Loading

arielb1 commented Dec 14, 2018

nikomatsakis commented Dec 17, 2018

bors commented Dec 17, 2018

nikomatsakis commented Dec 17, 2018

bors commented Dec 18, 2018

bors commented Dec 18, 2018

Centril commented Dec 21, 2018

arielb1 commented Dec 21, 2018 • edited Loading

Centril commented Dec 21, 2018

arielb1 commented Dec 21, 2018

alexreg commented Dec 21, 2018

arielb1 commented Dec 3, 2018 •

edited

Loading

nikomatsakis commented Dec 13, 2018 •

edited

Loading

arielb1 commented Dec 21, 2018 •

edited

Loading