-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the invariant for principal
inside the method
#55032
Check the invariant for principal
inside the method
#55032
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This looks reasonable to me, presuming I've understood. To clarify, this is fine because all Dynamic (i.e. trait objects) are currently required to have a principal, right? If so, then r=me once tests are passing |
yes, the way you create such objects is by giving them a principal (If I'm reading the code correctly) Also, like 10% of the code calling @bors r=Mark-Simulacrum |
📌 Commit 585490d has been approved by |
⌛ Testing commit 585490d with merge 87fceb15a7b91e37fb7c3df06ecda090b6af01bb... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
…k-Simulacrum Check the invariant for `principal` inside the method r? @Mark-Simulacrum
☀️ Test successful - status-appveyor, status-travis |
📣 Toolstate changed by #55032! Tested on commit 14f42a7. 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). |
Tested on commit rust-lang/rust@14f42a7. Direct link to PR: <rust-lang/rust#55032> 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 💔 rls on windows: test-pass → build-fail (cc @nrc, @rust-lang/infra). 💔 rls on linux: test-pass → build-fail (cc @nrc, @rust-lang/infra).
r? @Mark-Simulacrum