Correctly account for niche-optimized tags in rustc_transmute #130371
+34
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compiler-errors
approved these changes
Sep 14, 2024
| @@ -359,7 +365,7 @@ pub(crate) mod rustc { | |||
| let variants = def.discriminants(cx.tcx()).try_fold( | |||
| Self::uninhabited(), | |||
| |variants, (idx, ref discriminant)| { | |||
| let variant = layout_of_variant(idx)?; | |||
| let variant = layout_of_variant(idx, Some(tag_encoding.clone()))?; | |||
There was a problem hiding this comment.
the fact that RangeInclusive is not Copy is criminal tbh
|
r=me when green |
|
@bors r=compiler-errors |
|
Tremendous thanks for this @saethlin!!! |
Please keep me posted about this experiment! It sounds like a great way to burn down ICEs in |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 15, 2024
… r=compiler-errors Correctly account for niche-optimized tags in rustc_transmute This is a bit hacky, but it fixes the ICE and makes it possible to run the safe transmute check on every `mem::transmute` check we instantiate. I want to write a lint that needs to do that, but this stands well on its own. cc `@jswrenn` here's the fix I alluded to yesterday :) Fixes rust-lang#123693
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 15, 2024
… r=compiler-errors Correctly account for niche-optimized tags in rustc_transmute This is a bit hacky, but it fixes the ICE and makes it possible to run the safe transmute check on every `mem::transmute` check we instantiate. I want to write a lint that needs to do that, but this stands well on its own. cc `@jswrenn` here's the fix I alluded to yesterday :) Fixes rust-lang#123693
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 15, 2024
… r=compiler-errors Correctly account for niche-optimized tags in rustc_transmute This is a bit hacky, but it fixes the ICE and makes it possible to run the safe transmute check on every `mem::transmute` check we instantiate. I want to write a lint that needs to do that, but this stands well on its own. cc ``@jswrenn`` here's the fix I alluded to yesterday :) Fixes rust-lang#123693
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2024
…kingjubilee Rollup of 3 pull requests Successful merges: - rust-lang#130295 (Fix target-cpu fpu features on Armv8-R.) - rust-lang#130325 (Use -0.0 in `intrinsics::simd::reduce_add_unordered`) - rust-lang#130371 (Correctly account for niche-optimized tags in rustc_transmute) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#129195 (Stabilize `&mut` (and `*mut`) as well as `&Cell` (and `*const Cell`) in const) - rust-lang#130118 (move Option::unwrap_unchecked into const_option feature gate) - rust-lang#130295 (Fix target-cpu fpu features on Armv8-R.) - rust-lang#130371 (Correctly account for niche-optimized tags in rustc_transmute) - rust-lang#130381 (library: Compute Rust exception class from its string repr) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2024
Rollup merge of rust-lang#130371 - saethlin:transmutability-enum-ice, r=compiler-errors Correctly account for niche-optimized tags in rustc_transmute This is a bit hacky, but it fixes the ICE and makes it possible to run the safe transmute check on every `mem::transmute` check we instantiate. I want to write a lint that needs to do that, but this stands well on its own. cc `@jswrenn` here's the fix I alluded to yesterday :) Fixes rust-lang#123693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit hacky, but it fixes the ICE and makes it possible to run the safe transmute check on every
mem::transmutecheck we instantiate. I want to write a lint that needs to do that, but this stands well on its own.cc @jswrenn here's the fix I alluded to yesterday :)
Fixes #123693