Add proper cfgs for struct HirIdValidator used only with debug-assert

[mu001999]

See #122065 (comment).
I think it's due to #121752.

[rustbot]

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[oli-obk]

Thanks!

@bors r+ rollup

[bors]

📌 Commit f415379 has been approved by oli-obk

It is now in the queue for this repository.

[matthiaskrgr]

@bors r-
#122096 (comment)

[mu001999]

Why did the documenting fail?

   Documenting rustc_interface v0.0.0 (/Users/runner/work/rust/rust/compiler/rustc_interface)
   Documenting rustc_mir_transform v0.0.0 (/Users/runner/work/rust/rust/compiler/rustc_mir_transform)
  error[E0433]: failed to resolve: could not resolve path `rustc_passes::hir_id_validator::check_crate`
     --> compiler/rustc_interface/src/passes.rs:694:5
      |
  694 |     rustc_passes::hir_id_validator::check_crate(tcx);
      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not resolve path `rustc_passes::hir_id_validator::check_crate`
      |
      = note: this error was originally ignored because you are running `rustdoc`
      = note: try running again with `rustc` or `cargo check` and you may get a more detailed error
  
  For more information about this error, try `rustc --explain E0433`.
  error: could not document `rustc_interface`

[oli-obk]

probably some cfg shenanigans going on in rustdoc. try rerunning with MAGIC_EXTRA_RUSTFLAGS=-Ztreat-err-as-bug to get a backtrace of where the error occurs, maybe something obvious stands out

cc @rust-lang/rustdoc any idea what's up here? rustdoc is trying to resolve a function call in cfged out code

[Nemo157]

Maybe related to usage of --generate-link-to-definition and this FIXME

rust/src/librustdoc/html/render/span_map.rs

Lines 161 to 167 in 1508a03

	// FIXME: this is showing error messages for parts of the code that are not
	// compiled (because of cfg)!
	//
	// See discussion in https://github.com/rust-lang/rust/issues/69426#issuecomment-1019412352
	let typeck_results = self
	.tcx
	.typeck_body(hir.maybe_body_owned_by(body_id).expect("a body which isn't a body"));

[oli-obk]

@mu001999 you can remove the --generate-link-to-definition flags from bootstrap until that FIXME is resolved.

[oli-obk]

@bors r+ rollup

[bors]

📌 Commit 71d35d8 has been approved by oli-obk

It is now in the queue for this repository.