Rollup of 7 pull requests #119760

matthiaskrgr · 2024-01-09T04:33:24Z

Successful merges:

Add -Zuse-sync-unwind #117744 (Add -Zuse-sync-unwind)
Make inductive cycles in coherence ambiguous always #118649 (Make inductive cycles in coherence ambiguous always)
Use assert_unsafe_precondition for char::from_u32_unchecked #118979 (Use assert_unsafe_precondition for char::from_u32_unchecked)
mir-opt and custom target fixes #119619 (mir-opt and custom target fixes)
Fix broken build for ESP IDF due to #119026 #119632 (Fix broken build for ESP IDF due to std::net::bind using -1 for openbsd which in turn sets it to somaxconn. #119026)
Adding alignment to the cases to test for specific error messages. #119712 (Adding alignment to the cases to test for specific error messages.)
Miri subtree update #119734 (Miri subtree update)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Co-Authored-By: joboet <[email protected]>

This flag specifies whether LLVM generates async unwind or sync unwind.

Automatic Rustup

remove redundant clone

Automatic Rustup

use jemalloc as global allocator Hopefully fixes rust-lang/miri#3255

implement the rounding intrinsics using apfloat rounding No reason to use host floats for these. Also merge two files that were both testing various float things.

./miri build: also build tests, to avoid rebuilds later

…age. Covers `>`, `^` and `<`.

Check if tier 2 targets build in the nightly cron job This PR adds a CI job that only runs nightly which will install Miri built from the latest commit, and try to build every Tier 2 without host tools target, as documented on https://doc.rust-lang.org/nightly/rustc/platform-support.html. I'm not really excited about the idea of scraping the tier 2 without host tools list, but also keeping the list up-to-date by hand seems prone to forgetting to update it. And that update seems like the sort of manual maintenance we should automate.

only use jemalloc on Linux and macOS hopefully fixes [this](rust-lang#119707 (comment))

Signed-off-by: onur-ozkan <[email protected]>

Add -Zuse-sync-unwind Currently Rust uses async unwind by default, but async unwind will bring non-negligible size overhead. it would be nice to allow users to choose this. In addition, async unwind currently prevents LLVM from generate compact unwind for MachO, if one wishes to generate compact unwind for MachO, then also needs this flag.

…=lcnr Make inductive cycles in coherence ambiguous always Logical conclusion of rust-lang#114040 One step after rust-lang#116493 cc rust-lang/trait-system-refactor-initiative#20 r? lcnr to kick off the FCP after review... maybe we should wait until 1.75 is landed? In that case, I'd still like to get the FCP boxes checked sooner since that'll be near the holidays which means everyone's away.

…ieb,dtolnay Use `assert_unsafe_precondition` for `char::from_u32_unchecked` Use `assert_unsafe_precondition` in `char::from_u32_unchecked` so that it can be stabilized as `const`.

…oli-obk mir-opt and custom target fixes From rust-lang#115642 (comment) > > Could you please test the last two commits from https://github.com/onur-ozkan/rust/commits/panic-abort-mir-opt when you have the time? The first commit should resolve the error of using the nightly flag with a stable compiler, and the second one should resolve the custom target issue. > I tested with the two commits and the errors of using nightly flag and custom target specs were not seen. Testing was completed for the test suites like ui, run-pass-valgrind, coverage, mir-opt, codegen, assembly, incremental. Fixes rust-lang#115642

Fix broken build for ESP IDF due to rust-lang#119026 `target_os = "espidf"` in `libc` lacks the `SOMAXCONN` constant, but that's probably irrelevant in this context, as `UnixListener` is not supported on ESP IDF - it being a single process "OS" only. The PR just re-uses the `128` constant so that the code builds. Trying to use the listener on ESP IDF will fail with `ENOSYS`, which is fine. *UPDATE* Might not fail with `ENOSYS` - need to test what error code would be returned, but that doesn`t change anything.

Adding alignment to the cases to test for specific error messages. Adding alignment to the list of cases to test for specific error message. Covers `>`, `^` and `<`. Pinging people who chimed in last time ( rust-lang#106805 ): ``@estebank`` , ``@compiler-errors`` and ``@Nilstrieb``

Miri subtree update r? ``@ghost``

matthiaskrgr · 2024-01-09T04:34:00Z

@bors r+ rollup=never p=7

bors · 2024-01-09T04:34:03Z

📌 Commit 91fcc17 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-01-09T04:58:57Z

⌛ Testing commit 91fcc17 with merge 387e7a5...

bors · 2024-01-09T06:56:56Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 387e7a5 to master...

rust-timer · 2024-01-09T06:58:54Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#117744	Add -Zuse-sync-unwind	`dafa5f6991ee5e4973591826cb6b22dd6f1d6739` (link)
#118649	Make inductive cycles in coherence ambiguous always	`f3b1d7a90c7d9404f2a6c67731e696b8ee1205a8` (link)
#118979	Use `assert_unsafe_precondition` for `char::from_u32_unchec…	`a1b85c5e542b3645e330d64b3e78f8469949e08f` (link)
#119619	mir-opt and custom target fixes	`e23f2f2a57f448edade1274dafe887a843725db7` (link)
#119632	Fix broken build for ESP IDF due to #119026	`ca023604c20855b9eca06cb91790881ac5cf5ead` (link)
#119712	Adding alignment to the cases to test for specific error me…	`c86bcf559e1b6f4925b2f15015ccd52844f27a36` (link)
#119734	Miri subtree update	`dbd19554ec0b00875f83d7535691522b41165800` (link)

previous master: a399117774

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-01-09T08:14:16Z

Finished benchmarking commit (387e7a5): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	0.3%	[0.3%, 0.3%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[1.7%, 4.1%]	2
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-3.1%	[-3.6%, -2.3%]	4
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-1.1%	[-3.6%, 4.1%]	6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.1%, -0.0%]	17
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-0.1%, 0.0%]	21

Bootstrap: 668.946s -> 669.826s (0.13%)
Artifact size: 308.45 MiB -> 308.53 MiB (0.03%)

ChrisDenton and others added 30 commits December 15, 2023 15:15

Use assert_unsafe_precondition for char::from_u32_unchecked

ab716d0

Co-Authored-By: joboet <[email protected]>

Add -Zuse-sync-unwind

12784c3

This flag specifies whether LLVM generates async unwind or sync unwind.

Preparing for merge from rustc

4c4c6a6

Merge from rustc

d11a2bd

Auto merge of rust-lang#3252 - rust-lang:rustup-2024-01-05, r=RalfJung

39c714b

Automatic Rustup

Fix broken build for ESP IDF due to rust-lang#119026

a10b3cd

remove redundant clone

80ee0c0

Auto merge of rust-lang#3253 - matthiaskrgr:noclone, r=RalfJung

d334a4b

remove redundant clone

Preparing for merge from rustc

7e4e9ad

Merge from rustc

078f228

fmt

46f53c8

implement the rounding intrinsics using apfloat rounding

1c98b78

merge intrinsics-math into float tests

58c80a0

these should be exact

ac4526d

Auto merge of rust-lang#3254 - rust-lang:rustup-2024-01-06, r=saethlin

0814a56

Automatic Rustup

./miri build: also build tests, to avoid rebuilds later

643e7f0

cargo update

66b15ae

use jemalloc as global allocator

b8209e2

only use jemalloc on Unix

c4a11ea

Auto merge of rust-lang#3259 - RalfJung:jemalloc, r=RalfJung

d93ca6e

use jemalloc as global allocator Hopefully fixes rust-lang/miri#3255

Auto merge of rust-lang#3256 - RalfJung:rounding, r=RalfJung

8675aa1

implement the rounding intrinsics using apfloat rounding No reason to use host floats for these. Also merge two files that were both testing various float things.

Auto merge of rust-lang#3257 - RalfJung:build-tests, r=RalfJung

6f017d2

./miri build: also build tests, to avoid rebuilds later

Adding alignment to the list of cases to test for specific error mess…

5b30586

…age. Covers `>`, `^` and `<`.

Check if tier 2 targets build in the nightly cron job

7d5de70

only use jemalloc on Linux and macOS

56ff1b8

Auto merge of rust-lang#3261 - RalfJung:jemalloc, r=RalfJung

8d4a5c7

only use jemalloc on Linux and macOS hopefully fixes [this](rust-lang#119707 (comment))

update lockfile

0ddccf9

enable RUSTC_BOOTSTRAP on panic=abort mir-opt test

8aa7dd0

Signed-off-by: onur-ozkan <[email protected]>

detect user-specified custom targets in compiletest

26c71cb

Signed-off-by: onur-ozkan <[email protected]>

matthiaskrgr added 7 commits January 9, 2024 05:33

Rollup merge of rust-lang#118979 - ChrisDenton:unwrap-const, r=Nilstr…

b0c492c

…ieb,dtolnay Use `assert_unsafe_precondition` for `char::from_u32_unchecked` Use `assert_unsafe_precondition` in `char::from_u32_unchecked` so that it can be stabilized as `const`.

Rollup merge of rust-lang#119734 - RalfJung:miri, r=RalfJung

91fcc17

Miri subtree update r? ``@ghost``

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 9, 2024

bors merged commit 387e7a5 into rust-lang:master Jan 9, 2024
12 checks passed

rustbot added this to the 1.77.0 milestone Jan 9, 2024

This was referenced Jan 9, 2024

make matching on NaN a hard error, and remove the rest of illegal_floating_point_literal_pattern #116284

Merged

Update measureme crate to version 11 #119111

Merged

ARMv6K HorizonOS - Fix backlog for UnixListener #119742

Merged

pnkfelix mentioned this pull request Jan 16, 2024

Support async recursive calls (as long as they have indirection) #117703

Merged

matthiaskrgr deleted the rollup-ti2xpp7 branch March 16, 2024 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 7 pull requests #119760

Rollup of 7 pull requests #119760

matthiaskrgr commented Jan 9, 2024

matthiaskrgr commented Jan 9, 2024

bors commented Jan 9, 2024

bors commented Jan 9, 2024

bors commented Jan 9, 2024

rust-timer commented Jan 9, 2024

rust-timer commented Jan 9, 2024

Rollup of 7 pull requests #119760

Rollup of 7 pull requests #119760

Conversation

matthiaskrgr commented Jan 9, 2024

matthiaskrgr commented Jan 9, 2024

bors commented Jan 9, 2024

bors commented Jan 9, 2024

bors commented Jan 9, 2024

rust-timer commented Jan 9, 2024

rust-timer commented Jan 9, 2024

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size