rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 2) #116432

notriddle · 2023-10-04T20:05:32Z

rustbot · 2023-10-04T20:05:41Z

(rustbot has picked a reviewer for you, use r? to override)

notriddle · 2023-10-04T20:09:08Z

tests/rustdoc/issue-23106.rs

Renamed doctest-hide-empty-line-23106.rs

If you review commit-by-commit, it shows what actually happened (and git blame seems to be able to follow it, too), but the PR Files tab is buggy here.

fmease · 2023-10-04T20:53:18Z

Thanks!
@bors r+ rollup

bors · 2023-10-04T20:53:20Z

📌 Commit a46ccd8 has been approved by fmease

It is now in the queue for this repository.

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 2) Follow up rust-lang#116214

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#116223 (Fix misuses of a vs an) - rust-lang#116296 (More accurately point to where default return type should go) - rust-lang#116402 (Panic when the global allocator tries to register a TLS destructor) - rust-lang#116429 (Diagnostics: Be more careful when suggesting struct fields) - rust-lang#116431 (Tweak wording of E0562) - rust-lang#116432 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 2)) r? `@ghost` `@rustbot` modify labels: rollup

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 2) Follow up rust-lang#116214

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#115304 (Allow file names to end with '>') - rust-lang#116223 (Fix misuses of a vs an) - rust-lang#116296 (More accurately point to where default return type should go) - rust-lang#116429 (Diagnostics: Be more careful when suggesting struct fields) - rust-lang#116431 (Tweak wording of E0562) - rust-lang#116432 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 2)) r? `@ghost` `@rustbot` modify labels: rollup

…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#116223 (Fix misuses of a vs an) - rust-lang#116296 (More accurately point to where default return type should go) - rust-lang#116429 (Diagnostics: Be more careful when suggesting struct fields) - rust-lang#116431 (Tweak wording of E0562) - rust-lang#116432 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 2)) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116432 - notriddle:master, r=fmease rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 2) Follow up rust-lang#116214

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 3) Follow up * rust-lang#116214 * rust-lang#116432

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 4) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 4) Follow up * rust-lang/rust#116214 * rust-lang/rust#116432 * rust-lang/rust#116824

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 5) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105

Rollup merge of rust-lang#119561 - notriddle:master, r=fmease rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 5) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 6) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561

Rollup merge of rust-lang#123574 - notriddle:notriddle/issue-d, r=fmease rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 6) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 7) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561 * rust-lang#123574 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.

Rollup merge of rust-lang#125382 - notriddle:notriddle/issue-d, r=fmease rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 7) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561 * rust-lang#123574 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 7) Follow up * rust-lang/rust#116214 * rust-lang/rust#116432 * rust-lang/rust#116824 * rust-lang/rust#118105 * rust-lang/rust#119561 * rust-lang/rust#123574 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.

Update Rust toolchain from nightly-2023-10-05 to nightly-2023-10-06 without any other source changes. This is an automatically generated pull request. If any of the CI checks fail, manual intervention is required. In such a case, review the changes at https://github.com/rust-lang/rust from rust-lang@2bbb619 up to rust-lang@cae0791. The log for this commit range is: rust-lang@cae0791da4 Auto merge of rust-lang#116417 - ouz-a:trait_type_detective, r=compiler-errors rust-lang@e30d27be00 remove is global hack rust-lang@cdca82c2c8 Auto merge of rust-lang#116455 - matthiaskrgr:rollup-p226a5u, r=matthiaskrgr rust-lang@76d0b794cb Rollup merge of rust-lang#116452 - cjgillot:noassert-erased, r=oli-obk rust-lang@c1c5ab717e Rollup merge of rust-lang#116428 - Alexendoo:note-duplicate-diagnostics, r=compiler-errors,estebank rust-lang@08cc7428d9 Rollup merge of rust-lang#116415 - ouz-a:move_subtyper, r=oli-obk rust-lang@b301bd4220 Rollup merge of rust-lang#116288 - ouz-a:smir_spans, r=spastorino rust-lang@864e5d8d94 Rollup merge of rust-lang#116220 - llogiq:stabilize-option-as-slice, r=BurntSushi rust-lang@3088c4b046 move subtyper change reveal_all rust-lang@14c846cb05 Do not assert that hidden types don't have erased regions. rust-lang@3bcad65fbf Auto merge of rust-lang#103046 - JanBeh:PR_clarify_cmp_terminology, r=workingjubilee rust-lang@cf9fd95b1c Auto merge of rust-lang#114042 - liushuyu:ubuntu/i586-fpmath, r=workingjubilee rust-lang@86b031b734 docs: Correct terminology in std::cmp rust-lang@90f3a6f920 Auto merge of rust-lang#104153 - tspiteri:doc-float-constants, r=workingjubilee rust-lang@5c3a0e932b Auto merge of rust-lang#116427 - cjgillot:no-internal, r=oli-obk rust-lang@a49138e46e impl stable for kinds rust-lang@a79567b01c add span to statements rust-lang@e293927016 Auto merge of rust-lang#116443 - workingjubilee:rollup-r9mh13f, r=workingjubilee rust-lang@4a14a80605 Rollup merge of rust-lang#116432 - notriddle:master, r=fmease rust-lang@d7b02c3d40 Rollup merge of rust-lang#116431 - estebank:issue-80476, r=compiler-errors rust-lang@a9a389cf44 Rollup merge of rust-lang#116429 - fmease:clean-up-struct-field-suggs, r=compiler-errors rust-lang@cfce3a919d Rollup merge of rust-lang#116296 - compiler-errors:default-return, r=estebank rust-lang@ea3454eabb Rollup merge of rust-lang#116223 - catandcoder:master, r=cjgillot rust-lang@5236c8e1fa Auto merge of rust-lang#116273 - compiler-errors:refine2, r=tmandry rust-lang@b781645332 Auto merge of rust-lang#116184 - compiler-errors:afit-lint, r=tmandry rust-lang@5453a9f34d Add a note to duplicate diagnostics rust-lang@afe67fa2ef Auto merge of rust-lang#116370 - nnethercote:more-arena-stuff, r=cjgillot rust-lang@2f5249019e Apply suggestions from code review rust-lang@dd5f26c42d Fix spans for comments in rustfmt rust-lang@1f079cfb44 Point to closure return instead of output if defaulted rust-lang@89b14ae212 Fix clippy rust-lang@137b6d0b01 Point to where missing return type should go rust-lang@a46ccd8d3f Add URL to test case issues rust-lang@9266270ef5 Rename issue-\d+.rs tests to have meaningful names rust-lang@041e54bd92 Tweak wording of E0562 rust-lang@867cc41b5b clean up struct field suggestions rust-lang@a198aff4a4 Add `crate_name` to test so that it can be renamed rust-lang@e63d19c4dd Remove mir::LocalDecl::internal. rust-lang@f44d116e1f Fix misuses of a vs an rust-lang@a2051dd578 Optimize some `alloc_from_iter` call sites. rust-lang@816383c60d Remove the `TypedArena::alloc_from_iter` specialization. rust-lang@c373d206cd Address review nits rust-lang@90dfa24415 Only reachable traits rust-lang@afea0b4eab Fill in prose to describe the `async_fn_in_trait` lint rust-lang@28d58f6524 Bless tests rust-lang@ec79720c1e Add async_fn_in_trait lint rust-lang@999a354a81 add span to terminator rust-lang@9130484db9 create localdecl and add span to it rust-lang@06d9602d33 Only trigger refine lint on reachable traits rust-lang@702da3b89c stabilize `Option::as_`(`mut_`)`slice` rust-lang@40a52cf55c core library: Disable fpmath tests for i386 ... rust-lang@c953b6c014 doc: expand description for f32 and f64 associated constants Co-authored-by: celinval <[email protected]>

…k-Simulacrum rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 8) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561 * rust-lang#123574 * rust-lang#125382 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.

Rollup merge of rust-lang#127671 - notriddle:notriddle/issue-d, r=Mark-Simulacrum rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 8) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561 * rust-lang#123574 * rust-lang#125382 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 8) Follow up * rust-lang/rust#116214 * rust-lang/rust#116432 * rust-lang/rust#116824 * rust-lang/rust#118105 * rust-lang/rust#119561 * rust-lang/rust#123574 * rust-lang/rust#125382 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.

…youxu rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 9) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561 * rust-lang#123574 * rust-lang#125382 * rust-lang#127671 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.

Rollup merge of rust-lang#130287 - notriddle:notriddle/issue-d, r=jieyouxu rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 9) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561 * rust-lang#123574 * rust-lang#125382 * rust-lang#127671 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 9) Follow up * rust-lang/rust#116214 * rust-lang/rust#116432 * rust-lang/rust#116824 * rust-lang/rust#118105 * rust-lang/rust#119561 * rust-lang/rust#123574 * rust-lang/rust#125382 * rust-lang/rust#127671 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.

notriddle added 3 commits October 4, 2023 12:13

Add crate_name to test so that it can be renamed

a198aff

Rename issue-\d+.rs tests to have meaningful names

9266270

Add URL to test case issues

a46ccd8

rustbot assigned Mark-Simulacrum Oct 4, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 4, 2023

notriddle commented Oct 4, 2023

View reviewed changes

fmease assigned fmease and unassigned Mark-Simulacrum Oct 4, 2023

fmease approved these changes Oct 4, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2023

matthiaskrgr mentioned this pull request Oct 5, 2023

Rollup of 6 pull requests #116441

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 5, 2023

Rollup merge of rust-lang#116432 - notriddle:master, r=fmease

1910b69

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 2) Follow up rust-lang#116214

matthiaskrgr mentioned this pull request Oct 5, 2023

Rollup of 6 pull requests #116442

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 5, 2023

Rollup merge of rust-lang#116432 - notriddle:master, r=fmease

e988e02

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 2) Follow up rust-lang#116214

workingjubilee mentioned this pull request Oct 5, 2023

Rollup of 5 pull requests #116443

Merged

bors merged commit 4a14a80 into rust-lang:master Oct 5, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 5, 2023

pvdrz mentioned this pull request Oct 6, 2023

Fix divergence from upstream master ferrocene/ferrocene#23

Merged

notriddle mentioned this pull request Oct 16, 2023

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 3) #116824

Merged

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 17, 2023

Auto merge of rust-lang#116824 - notriddle:master, r=fmease

ddef56d

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 3) Follow up * rust-lang#116214 * rust-lang#116432

notriddle mentioned this pull request Nov 20, 2023

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 4) #118105

Merged

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2023

Auto merge of rust-lang#118105 - notriddle:master, r=fmease

eab8c7d

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 4) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824

notriddle mentioned this pull request Jan 3, 2024

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 5) #119561

Merged

notriddle mentioned this pull request Apr 6, 2024

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 6) #123574

Merged

notriddle mentioned this pull request May 21, 2024

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 7) #125382

Merged

notriddle mentioned this pull request Jul 13, 2024

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 8) #127671

Merged

notriddle mentioned this pull request Sep 12, 2024

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 9) #130287

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 2) #116432

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 2) #116432

notriddle commented Oct 4, 2023

rustbot commented Oct 4, 2023

notriddle Oct 4, 2023

fmease commented Oct 4, 2023

bors commented Oct 4, 2023

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 2) #116432

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 2) #116432

Conversation

notriddle commented Oct 4, 2023

rustbot commented Oct 4, 2023

notriddle Oct 4, 2023

Choose a reason for hiding this comment

fmease commented Oct 4, 2023

bors commented Oct 4, 2023

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 2) #116432

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 2) #116432