Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add char::MIN #114299

Merged
merged 5 commits into from
Sep 8, 2023
Merged

Add char::MIN #114299

merged 5 commits into from
Sep 8, 2023

Conversation

clarfonthey
Copy link
Contributor

ACP: rust-lang/libs-team#252
Tracking issue: #114298

r? @rust-lang/libs-api

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 31, 2023
@clarfonthey clarfonthey mentioned this pull request Jul 31, 2023
4 tasks
@rust-log-analyzer

This comment has been minimized.

library/core/src/char/methods.rs Outdated Show resolved Hide resolved
library/core/src/char/methods.rs Show resolved Hide resolved
Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rust-log-analyzer

This comment has been minimized.

@clarfonthey
Copy link
Contributor Author

(should be ready to merge now)

@dtolnay dtolnay assigned dtolnay and unassigned BurntSushi Sep 7, 2023
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Sep 7, 2023

@bors r=dtolnay,BurntSushi

@bors
Copy link
Contributor

bors commented Sep 7, 2023

📌 Commit 9fce8ab has been approved by dtolnay,BurntSushi

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2023
@bors
Copy link
Contributor

bors commented Sep 8, 2023

⌛ Testing commit 9fce8ab with merge feb0673...

@bors
Copy link
Contributor

bors commented Sep 8, 2023

☀️ Test successful - checks-actions
Approved by: dtolnay,BurntSushi
Pushing feb0673 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 8, 2023
@bors bors merged commit feb0673 into rust-lang:master Sep 8, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 8, 2023
@clarfonthey clarfonthey deleted the char-min branch September 8, 2023 02:39
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (feb0673): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [0.6%, 2.1%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.9% [-6.3%, -1.5%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.8% [-1.8%, -1.8%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 627.948s -> 628.971s (0.16%)
Artifact size: 318.11 MiB -> 318.08 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants