Enable type privacy lints in rustc #113284

Bryanskiy · 2023-07-03T10:37:54Z

rustbot · 2023-07-03T10:38:05Z

Some changes occurred in diagnostic error codes

Portable SIMD is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead.

cc @calebzulawski, @programmerjake

Bryanskiy · 2023-07-03T11:06:43Z

@rustbot author

library/portable-simd/crates/core_simd/src/masks.rs

rustbot · 2023-07-03T16:41:19Z

Some changes occurred in src/tools/rust-analyzer

cc @rust-lang/rust-analyzer

src/tools/rust-analyzer/crates/profile/src/hprof.rs

library/core/src/array/drain.rs

src/bootstrap/builder.rs

src/bootstrap/bin/rustc.rs

library/core/src/array/drain.rs

library/core/src/fmt/rt.rs

library/proc_macro/src/bridge/buffer.rs

library/std/src/sys/unix/process/process_common.rs

library/test/src/event.rs

petrochenkov · 2023-07-13T15:52:19Z

Blocked on #113637.

bjorn3 · 2023-07-14T11:48:46Z

src/tools/rust-analyzer/lib/la-arena/src/lib.rs

@@ -1,5 +1,7 @@
 //! Yet another index-based arena.

+#![feature(type_privacy_lints)]


Rust-analyzer must build on stable, so enabling feature gates is not an option.

petrochenkov · 2023-07-14T13:05:23Z

From the examples in this PR it seems pretty clear to me that we should only report unnameable_types for publicly reachable items (reachable_at_vis == pub).
The lint is about public interfaces provided to third parties, and if something is unnameable internally it's not a big deal, can be changed at any time if necessary, and reporting it only results in noise.

petrochenkov · 2023-07-14T13:07:16Z

Also, #113637 has landed, so all cfg_attrs and cfg(bootstraps)s are no longer necessary, and the options can be added to bootstrap.py too.

bjorn3 · 2023-07-14T14:21:36Z

From the examples in this PR it seems pretty clear to me that we should only report unnameable_types for publicly reachable items (reachable_at_vis == pub).
The lint is about public interfaces provided to third parties, and if something is unnameable internally it's not a big deal, can be changed at any time if necessary, and reporting it only results in noise.

Is #[warn(unreachable_pub)] still a thing? That is where I expect reporting unnameable types which aren't used in public interfaces.

petrochenkov · 2023-07-14T14:40:28Z

@bjorn3
That lint is reported when nominal visibility is larger than reachability.
A type can, for example, be both reachable and nameable (aka reexported) in the whole crate, but report unreachable_pub because you overshoot with the nominal visibility annotation and set it to pub while it could be pub(crate).

unnameable_types is reported when a type is reachable farther than nameable (e.g. reachable in pub(crate) and nameable in pub(crate::foo)), regardless of its nominal visibility (which can be e.g. pub(crate), then unreachable_pub won't be reported).

petrochenkov · 2023-07-14T16:59:32Z

We cannot merge this until either #113702 is fixed, or unnameable_types is stabilized.

petrochenkov · 2023-07-14T17:19:35Z

@bjorn3 suggested using -Zcrate-attr=feature(type_privacy_lints) as a solution in #113702 (comment), reopening.

rustbot · 2023-07-15T11:40:11Z

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @TaKO8Ki

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred in need_type_info.rs

cc @lcnr

This PR changes Stable MIR

cc @oli-obk, @celinval

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

RalfJung · 2023-07-16T12:16:30Z

compiler/rustc_const_eval/src/interpret/visitor.rs

@@ -54,6 +54,8 @@ pub trait Value<'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>>: Sized {
 /// A thing that we can project into given *mutable* access to `ecx`, and that has a layout.
 /// This wouldn't have to depend on `Machine` but with the current type inference,
 /// that's just more convenient to work with (avoids repeating all the `Machine` bounds).
+#[allow(unnameable_types)]
+//~^ reachable at visibility `pub`, but can only be named at visibility `pub(interpret)`
 pub trait ValueMut<'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>>: Sized {


This is an oversight, it should be reexported in interpret/mod.rs like the Value trait

rust-log-analyzer · 2023-07-24T16:18:46Z

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[group]Run git config --global core.autocrlf false
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
  lfs: false
  submodules: false
  set-safe-directory: true
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/should-skip-this.sh
src/ci/scripts/should-skip-this.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/verify-channel.sh
src/ci/scripts/verify-channel.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/collect-cpu-stats.sh
src/ci/scripts/collect-cpu-stats.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/install-sccache.sh
src/ci/scripts/install-sccache.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/select-xcode.sh
src/ci/scripts/select-xcode.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/install-clang.sh
src/ci/scripts/install-clang.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/install-wix.sh
src/ci/scripts/install-wix.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/disable-git-crlf-conversion.sh
src/ci/scripts/disable-git-crlf-conversion.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/install-msys2.sh
src/ci/scripts/install-msys2.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/install-mingw.sh
src/ci/scripts/install-mingw.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/install-ninja.sh
src/ci/scripts/install-ninja.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/enable-docker-ipv6.sh
src/ci/scripts/enable-docker-ipv6.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/disable-git-crlf-conversion.sh
src/ci/scripts/disable-git-crlf-conversion.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/verify-line-endings.sh
src/ci/scripts/verify-line-endings.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
##[group]Run src/ci/scripts/verify-backported-commits.sh
src/ci/scripts/verify-backported-commits.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/verify-stable-version-number.sh
src/ci/scripts/verify-stable-version-number.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
##[group]Run src/ci/scripts/run-build-from-ci.sh
src/ci/scripts/run-build-from-ci.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  PR_CI_JOB: 1
  CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
  HEAD_SHA: 3759fd7f354ab167502815b07eb37615b0cd3a08
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
    = help: add `#![feature(type_privacy_lints)]` to the crate attributes to enable

error: aborting due to 2 previous errors

error: doctest failed, to rerun pass `-p alloc --doc`
Caused by:
Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2021 --crate-type lib --crate-name alloc --test library/alloc/src/lib.rs --test-run-directory /checkout/library/alloc --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/release/deps -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/build/compiler_builtins-6f72c4d83ddf41d8/out --test-args --quiet --test-args -Z --test-args unstable-options --test-args --format --test-args json --extern alloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps/liballoc-c9a35292c4dbb103.rlib --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-48cf648e48da91a5.rlib --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps/libcore-aabf06ff2fc71356.rlib --extern rand=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps/librand-026b02c908b147e3.rlib --extern rand_xorshift=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps/librand_xorshift-f382bb17f2f98635.rlib -C embed-bitcode=no --cfg 'feature="compiler-builtins-c"' -Zunstable-options --check-cfg 'names()' --check-cfg 'values()' --cfg=bootstrap -Csymbol-mangling-version=legacy -Zunstable-options -Zunstable-options '--check-cfg=values(bootstrap)' '--check-cfg=values(stdarch_intel_sde)' '--check-cfg=values(no_fp_fmt_parse)' '--check-cfg=values(no_global_oom_handling)' '--check-cfg=values(no_rc)' '--check-cfg=values(no_sync)' '--check-cfg=values(freebsd12)' '--check-cfg=values(freebsd13)' '--check-cfg=values(backtrace_in_libstd)' '--check-cfg=values(target_env,"libnx")' '--check-cfg=values(target_arch,"asmjs","spirv","nvptx","xtensa","mips32r6","mips64r6")' -Dwarnings '-Wrustdoc::invalid_codeblock_attributes' --crate-version '1.73.0-nightly (d98649d74 2023-07-24)' '-Zcrate-attr=doc(html_root_url="https://doc.rust-lang.org/nightly/")' '-Zcrate-attr=warn(rust_2018_idioms)' --error-format human` (exit status: 1)
##[group]Clock drift check
  local time: Mon Jul 24 16:18:35 UTC 2023
  network time: Mon, 24 Jul 2023 16:18:35 GMT
##[endgroup]

JohnCSimon · 2023-10-01T04:14:31Z

@Bryanskiy
ping from triage - can you post your status on this PR? There hasn't been an update in a few months. Thanks!

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

bors · 2023-10-17T10:49:38Z

☔ The latest upstream changes (presumably #116196) made this pull request unmergeable. Please resolve the merge conflicts.

Dylan-DPC · 2023-11-03T18:30:08Z

Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks

privacy: Stabilize lint `unnameable_types` This is the last piece of ["RFC rust-lang#2145: Type privacy and private-in-public lints"](rust-lang#48054). Having unstable lints is not very useful because you cannot even dogfood them in the compiler/stdlib in this case (rust-lang#113284). The worst thing that may happen when a lint is removed are some `removed_lints` warnings, but I haven't heard anyone suggesting removing this specific lint. This lint is allow-by-default and is supposed to be enabled explicitly. Some false positives are expected, because sometimes unnameable types are a legitimate pattern. This lint also have some unnecessary false positives, that can be fixed - see rust-lang#120146 and rust-lang#120149. Closes rust-lang#48054.

Rollup merge of rust-lang#120144 - petrochenkov:unty, r=davidtwco privacy: Stabilize lint `unnameable_types` This is the last piece of ["RFC rust-lang#2145: Type privacy and private-in-public lints"](rust-lang#48054). Having unstable lints is not very useful because you cannot even dogfood them in the compiler/stdlib in this case (rust-lang#113284). The worst thing that may happen when a lint is removed are some `removed_lints` warnings, but I haven't heard anyone suggesting removing this specific lint. This lint is allow-by-default and is supposed to be enabled explicitly. Some false positives are expected, because sometimes unnameable types are a legitimate pattern. This lint also have some unnecessary false positives, that can be fixed - see rust-lang#120146 and rust-lang#120149. Closes rust-lang#48054.

rustbot assigned petrochenkov Jul 3, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 3, 2023

Bryanskiy force-pushed the type-privacy branch from bf986cd to e06f438 Compare July 3, 2023 10:44

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2023

calebzulawski requested changes Jul 3, 2023

View reviewed changes

library/portable-simd/crates/core_simd/src/masks.rs Show resolved Hide resolved

Bryanskiy force-pushed the type-privacy branch from e06f438 to 95ac419 Compare July 3, 2023 16:41

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 3, 2023

Bryanskiy changed the title ~~Test unnameable_types lint~~ Enable type privacy lints in rustc Jul 3, 2023

This comment has been minimized.

Sign in to view

Veykril reviewed Jul 3, 2023

View reviewed changes

src/tools/rust-analyzer/crates/profile/src/hprof.rs Outdated Show resolved Hide resolved

Bryanskiy force-pushed the type-privacy branch from 95ac419 to 980cc82 Compare July 4, 2023 12:34

This comment has been minimized.

Sign in to view

petrochenkov reviewed Jul 4, 2023

View reviewed changes

Bryanskiy force-pushed the type-privacy branch from 980cc82 to 468e124 Compare July 4, 2023 14:56

This comment has been minimized.

Sign in to view

bjorn3 reviewed Jul 14, 2023

View reviewed changes

petrochenkov mentioned this pull request Jul 14, 2023

Unstable lints passed on command line can only be ungated from source code #113702

Closed

petrochenkov closed this Jul 14, 2023

petrochenkov reopened this Jul 14, 2023

This comment has been minimized.

Sign in to view

Bryanskiy force-pushed the type-privacy branch from b920050 to 6eac453 Compare July 15, 2023 11:40

This comment has been minimized.

Sign in to view

Mark-Simulacrum force-pushed the master branch from bef6ff6 to ad96323 Compare July 15, 2023 13:39

RalfJung reviewed Jul 16, 2023

View reviewed changes

Bryanskiy force-pushed the type-privacy branch from 6eac453 to 006128a Compare July 24, 2023 13:52

This comment has been minimized.

Sign in to view

Bryanskiy force-pushed the type-privacy branch from 006128a to 0c11ba1 Compare July 24, 2023 15:57

This comment has been minimized.

Sign in to view

Enable type privacy lints in rustc

3759fd7

Bryanskiy force-pushed the type-privacy branch from 0c11ba1 to 3759fd7 Compare July 24, 2023 16:10

Dylan-DPC closed this Nov 3, 2023

petrochenkov mentioned this pull request Jan 19, 2024

privacy: Stabilize lint unnameable_types #120144

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable type privacy lints in rustc #113284

Enable type privacy lints in rustc #113284

Bryanskiy commented Jul 3, 2023

rustbot commented Jul 3, 2023

This comment has been minimized.

Bryanskiy commented Jul 3, 2023

rustbot commented Jul 3, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Jul 13, 2023

This comment has been minimized.

bjorn3 Jul 14, 2023

petrochenkov commented Jul 14, 2023

petrochenkov commented Jul 14, 2023

bjorn3 commented Jul 14, 2023

petrochenkov commented Jul 14, 2023 •

edited

Loading

petrochenkov commented Jul 14, 2023

petrochenkov commented Jul 14, 2023

This comment has been minimized.

rustbot commented Jul 15, 2023

This comment has been minimized.

RalfJung Jul 16, 2023

This comment has been minimized.

This comment has been minimized.

rust-log-analyzer commented Jul 24, 2023

JohnCSimon commented Oct 1, 2023

bors commented Oct 17, 2023

Dylan-DPC commented Nov 3, 2023

		@@ -1,5 +1,7 @@
		//! Yet another index-based arena.

		#![feature(type_privacy_lints)]

Enable type privacy lints in rustc #113284

Enable type privacy lints in rustc #113284

Conversation

Bryanskiy commented Jul 3, 2023

rustbot commented Jul 3, 2023

This comment has been minimized.

Bryanskiy commented Jul 3, 2023

rustbot commented Jul 3, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Jul 13, 2023

This comment has been minimized.

bjorn3 Jul 14, 2023

Choose a reason for hiding this comment

petrochenkov commented Jul 14, 2023

petrochenkov commented Jul 14, 2023

bjorn3 commented Jul 14, 2023

petrochenkov commented Jul 14, 2023 • edited Loading

petrochenkov commented Jul 14, 2023

petrochenkov commented Jul 14, 2023

This comment has been minimized.

rustbot commented Jul 15, 2023

This comment has been minimized.

RalfJung Jul 16, 2023

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

rust-log-analyzer commented Jul 24, 2023

JohnCSimon commented Oct 1, 2023

bors commented Oct 17, 2023

Dylan-DPC commented Nov 3, 2023

petrochenkov commented Jul 14, 2023 •

edited

Loading